Skip to content
This repository has been archived by the owner on Dec 5, 2020. It is now read-only.

Fix saving window geometry #51 #54

Merged
merged 1 commit into from
Aug 19, 2016
Merged

Fix saving window geometry #51 #54

merged 1 commit into from
Aug 19, 2016

Conversation

kopr12
Copy link

@kopr12 kopr12 commented Aug 19, 2016

Tested and it works now.

@haecker-felix
Copy link
Owner

Thanks! Didn't except so much third party commits/pull requests during my holiday 👌

@haecker-felix haecker-felix merged commit f94c93c into haecker-felix:master Aug 19, 2016
@kopr12
Copy link
Author

kopr12 commented Aug 19, 2016

Hahah yeah, sorry about that, I missed it, it was calling save_geometry() both on destroy event and delete event, somehow when positions are saved from both events they are not saved properly (when close to tray option is disabled).
It was saving x and y as 1 always.
Have no clue why though :)
Anyway, there's no need for destroy event, I tested it and it works for sure now.

@haecker-felix
Copy link
Owner

Okay. Such "bugs" can be very annoying when they're not be found. Luckily you have taken this work for me :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants