Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved handling for validation in field groups #17

Open
Shadowfiend opened this issue Apr 19, 2017 · 0 comments
Open

Improved handling for validation in field groups #17

Shadowfiend opened this issue Apr 19, 2017 · 0 comments

Comments

@Shadowfiend
Copy link
Member

Currently field groups have withBoxedConverter, which can return a non-Full Box to indicate validation failures. There are, however, a couple of downsides to this approach:

  • The resulting failures have to be manually handled in onFailure, or the withBoxedConverter function has to explicitly invoke S.error to mark the client error.
  • The converter may produce an object of type T that is usually valid but isn't valid in the context of this form. This T may need further validation in this particular context.

Two things would help here:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant