From 3efcfe0592cc075aa48145a6c1f2c60bbe3a32a7 Mon Sep 17 00:00:00 2001 From: Michael Magen Date: Wed, 16 Nov 2022 11:14:55 -0800 Subject: [PATCH 1/3] Make toolkit guide cards WCAG compliant --- _guide-pages/2FA.html | 2 +- _guide-pages/creating-kanban-project.html | 2 +- _guide-pages/figma-for-opensource-projects.html | 2 +- _guide-pages/github-issues.html | 2 +- .../responsible-use-of-images-on-opensource-projects.html | 2 +- _guide-pages/setting-up-1password-on-opensource-project.html | 2 +- _guide-pages/showing-civictech-experience-on-linkedin.html | 2 +- _guide-pages/survey-reporting-dashboard-guide.html | 2 +- _guide-pages/updates-team-pages-on-hflasite.html | 2 +- _guide-pages/using-kanban-project.html | 2 +- _includes/guide-card.html | 2 +- {_includes/svg => assets/images/guides/2FA}/2FA.svg | 0 .../images/guides/survey-reporting}/survey-reporting-image.svg | 0 13 files changed, 11 insertions(+), 11 deletions(-) rename {_includes/svg => assets/images/guides/2FA}/2FA.svg (100%) rename {_includes/svg => assets/images/guides/survey-reporting}/survey-reporting-image.svg (100%) diff --git a/_guide-pages/2FA.html b/_guide-pages/2FA.html index a163101a4d..0eac8db28f 100644 --- a/_guide-pages/2FA.html +++ b/_guide-pages/2FA.html @@ -17,7 +17,7 @@ - Danielle Nedivi source: Hack for LA recommended-by: -svg: svg/2FA.svg +svg: /assets/images/guides/2FA/2FA.svg resource-url-completed: '/guide-pages/2FA' resource-url-wip: resource-url-depreciated: diff --git a/_guide-pages/creating-kanban-project.html b/_guide-pages/creating-kanban-project.html index 202616a744..c9f0563423 100644 --- a/_guide-pages/creating-kanban-project.html +++ b/_guide-pages/creating-kanban-project.html @@ -12,7 +12,7 @@ - Qiqi Zheng source: Hack for LA recommended-by: -svg: svg/default.svg +svg: /assets/images/toolkit-default-card-image.png resource-url-completed: '' resource-url-wip: resource-url-depreciated: diff --git a/_guide-pages/figma-for-opensource-projects.html b/_guide-pages/figma-for-opensource-projects.html index 7b441f90fe..3ddccf711c 100644 --- a/_guide-pages/figma-for-opensource-projects.html +++ b/_guide-pages/figma-for-opensource-projects.html @@ -11,7 +11,7 @@ contributors: source: Hack for LA recommended-by: -svg: svg/default.svg +svg: /assets/images/toolkit-default-card-image.png resource-url-completed: '' resource-url-wip: resource-url-depreciated: diff --git a/_guide-pages/github-issues.html b/_guide-pages/github-issues.html index 51e6c2b7c5..6819eaaa47 100644 --- a/_guide-pages/github-issues.html +++ b/_guide-pages/github-issues.html @@ -22,7 +22,7 @@ - Bonnie Wolfe source: Hack for LA recommended-by: -svg: svg/default.svg +svg: /assets/images/toolkit-default-card-image.png resource-url-completed: '/guide-pages/github-issues' resource-url-wip: resource-url-depreciated: diff --git a/_guide-pages/responsible-use-of-images-on-opensource-projects.html b/_guide-pages/responsible-use-of-images-on-opensource-projects.html index 3f64077792..7802feefe0 100644 --- a/_guide-pages/responsible-use-of-images-on-opensource-projects.html +++ b/_guide-pages/responsible-use-of-images-on-opensource-projects.html @@ -11,7 +11,7 @@ - Danielle Nedivi source: Hack for LA recommended-by: -svg: svg/default.svg +svg: /assets/images/toolkit-default-card-image.png resource-url-completed: '' resource-url-wip: resource-url-depreciated: diff --git a/_guide-pages/setting-up-1password-on-opensource-project.html b/_guide-pages/setting-up-1password-on-opensource-project.html index 583b085ed0..193f15be5f 100644 --- a/_guide-pages/setting-up-1password-on-opensource-project.html +++ b/_guide-pages/setting-up-1password-on-opensource-project.html @@ -12,7 +12,7 @@ - Jessica Cheng source: Hack for LA recommended-by: -svg: svg/default.svg +svg: /assets/images/toolkit-default-card-image.png resource-url-completed: '' resource-url-wip: resource-url-depreciated: diff --git a/_guide-pages/showing-civictech-experience-on-linkedin.html b/_guide-pages/showing-civictech-experience-on-linkedin.html index 405c19001b..933f8b20e2 100644 --- a/_guide-pages/showing-civictech-experience-on-linkedin.html +++ b/_guide-pages/showing-civictech-experience-on-linkedin.html @@ -13,7 +13,7 @@ - Bonnie Wolfe source: Hack for LA recommended-by: -svg: svg/default.svg +svg: /assets/images/toolkit-default-card-image.png resource-url-completed: '' resource-url-wip: resource-url-depreciated: diff --git a/_guide-pages/survey-reporting-dashboard-guide.html b/_guide-pages/survey-reporting-dashboard-guide.html index e3f7c372fd..aca23a8ce8 100644 --- a/_guide-pages/survey-reporting-dashboard-guide.html +++ b/_guide-pages/survey-reporting-dashboard-guide.html @@ -22,7 +22,7 @@ - Hannah Livnat source: Hack for LA recommended-by: -svg: svg/survey-reporting-image.svg +svg: /assets/images/guides/survey-reporting/survey-reporting-image.svg resource-url-completed: '/guide-pages/survey-reporting-dashboard-guide' resource-url-wip: resource-url-depreciated: diff --git a/_guide-pages/updates-team-pages-on-hflasite.html b/_guide-pages/updates-team-pages-on-hflasite.html index 68f25d10a8..60cdbc222f 100644 --- a/_guide-pages/updates-team-pages-on-hflasite.html +++ b/_guide-pages/updates-team-pages-on-hflasite.html @@ -12,7 +12,7 @@ contributors: source: Hack for LA recommended-by: -svg: svg/default.svg +svg: /assets/images/toolkit-default-card-image.png resource-url-completed: '' resource-url-wip: resource-url-depreciated: diff --git a/_guide-pages/using-kanban-project.html b/_guide-pages/using-kanban-project.html index d92292ba1b..d306d676b2 100644 --- a/_guide-pages/using-kanban-project.html +++ b/_guide-pages/using-kanban-project.html @@ -22,7 +22,7 @@ - Liyang Chen source: Hack for LA recommended-by: -svg: svg/default.svg +svg: /assets/images/toolkit-default-card-image.png resource-url-completed: '' resource-url-wip: resource-url-depreciated: diff --git a/_includes/guide-card.html b/_includes/guide-card.html index 13f0f8ba48..a31dd7a84e 100644 --- a/_includes/guide-card.html +++ b/_includes/guide-card.html @@ -4,7 +4,7 @@ {%- if guide.svg -%}
- {% include {{ guide.svg }} %} +
{%- endif -%} diff --git a/_includes/svg/2FA.svg b/assets/images/guides/2FA/2FA.svg similarity index 100% rename from _includes/svg/2FA.svg rename to assets/images/guides/2FA/2FA.svg diff --git a/_includes/svg/survey-reporting-image.svg b/assets/images/guides/survey-reporting/survey-reporting-image.svg similarity index 100% rename from _includes/svg/survey-reporting-image.svg rename to assets/images/guides/survey-reporting/survey-reporting-image.svg From cf078cb9a8f8a88eb7ff9af98939dd6bd355f479 Mon Sep 17 00:00:00 2001 From: Michael Magen Date: Thu, 17 Nov 2022 15:29:23 -0800 Subject: [PATCH 2/3] Fix toolkit guide card spacing --- _sass/components/_toolkit.scss | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/_sass/components/_toolkit.scss b/_sass/components/_toolkit.scss index 256041f530..1711d0e722 100644 --- a/_sass/components/_toolkit.scss +++ b/_sass/components/_toolkit.scss @@ -69,13 +69,15 @@ } .toolkit-flex-item-img-container { - max-height: 16.95rem; + height: 16em; overflow: hidden; } -.toolkit-flex-item-img-container svg { +.toolkit-flex-item-img-container svg, +.toolkit-flex-item-img-container img { width: 100%; height: 100%; + object-fit: cover; } .resource-svg-icons { From 90db3692f74acd00a15a9662e1368a9bb27f2398 Mon Sep 17 00:00:00 2001 From: Michael Magen Date: Tue, 22 Nov 2022 17:18:01 -0800 Subject: [PATCH 3/3] Fix toolkit guide card size in small viewports --- _sass/components/_toolkit.scss | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/_sass/components/_toolkit.scss b/_sass/components/_toolkit.scss index 1711d0e722..5c8a48b515 100644 --- a/_sass/components/_toolkit.scss +++ b/_sass/components/_toolkit.scss @@ -181,6 +181,14 @@ .external-resources-text { text-align: left; } + + .toolkit-flex-item-img-container { + height: auto; + + &.resource-svg-icons { + height: 15.5rem; + } + } } .toolkit-flex-item {