Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor GHAs so that Templates use label-directory.json #7687

Closed
3 of 5 tasks
Tracked by #6454
t-will-gillis opened this issue Nov 4, 2024 · 2 comments
Closed
3 of 5 tasks
Tracked by #6454

Refactor GHAs so that Templates use label-directory.json #7687

t-will-gillis opened this issue Nov 4, 2024 · 2 comments
Assignees
Labels
Complexity: Large Draft Issue is still in the process of being created Feature: Refactor GHA Refactoring GitHub actions to fit latest architectural norms role: back end/devOps Tasks for back-end developers size: 5pt Can be done in 19-30 hours

Comments

@t-will-gillis
Copy link
Member

t-will-gillis commented Nov 4, 2024

Overview

We are in the process of replacing all references to labels in our workflows from specifying a label name (labelName) to specifying a label key (labelKey) instead. (Refer to issues #6454 and #5205 for the history) We need to extend this to our templates as well.

Details

To accomplish this, we will replace all labels with a single placeholder label on each template- Template Label Placeholder or similar. When an issue is created from a template and this label is found, the correct labels should be applied to the template issue then the Template Label Holder should be removed.

It appears that this functionality can be created within check-labels.js.

Note that templates without the Template Label Placeholder will continue working using the full label names as they have been.

Action Items

  • In check-labels.js add functionality to detect the Template Label Placeholder on issue creation, and if so, substitute the correct labels.
  • The correct labels should be contained in a comment on the template's md file, then extracted
  • Afterwards, the Template Label Placeholder label itself should be removed.
  • Perform a test in your own repo that demonstrates that there is no change to the GHA's functionality after making the edits.
  • NOTE: before merging, the label for Template Label Placeholder will need to be created.

Resources/Instructions

@HackforLABot

This comment was marked as resolved.

@t-will-gillis t-will-gillis added the Draft Issue is still in the process of being created label Nov 5, 2024
@t-will-gillis
Copy link
Member Author

Closing issue: after discussion at the Monday meeting 11/25, it was decided that we will not label the templates with labelKey values and use the automation to insert the labelNames. Instead, we will change the template label names directly if needed.

@t-will-gillis t-will-gillis closed this as not planned Won't fix, can't repro, duplicate, stale Nov 28, 2024
@github-project-automation github-project-automation bot moved this from New Issue Approval to QA in P: HfLA Website: Project Board Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Large Draft Issue is still in the process of being created Feature: Refactor GHA Refactoring GitHub actions to fit latest architectural norms role: back end/devOps Tasks for back-end developers size: 5pt Can be done in 19-30 hours
Projects
Development

Successfully merging a pull request may close this issue.

2 participants