Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct misspelling in About page #7623

Closed
2 tasks done
essencegoff opened this issue Oct 22, 2024 · 4 comments · Fixed by #7712
Closed
2 tasks done

Correct misspelling in About page #7623

essencegoff opened this issue Oct 22, 2024 · 4 comments · Fixed by #7712
Assignees
Labels
feature: spelling good first issue Good for newcomers P-Feature: About Us https://www.hackforla.org/about/ role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours time sensitive Needs to be worked on by a particular timeframe
Milestone

Comments

@essencegoff
Copy link
Member

essencegoff commented Oct 22, 2024

Prerequisite

  1. Be a member of Hack for LA. (There are no fees to join.) If you have not joined yet, please follow the steps on our Getting Started page.
  2. Please make sure you have read our Hack for LA Contributing Guide before you claim/start working on an issue.

Overview

Our website needs to be free of misspellings so that our reputation for quality is maintained. In this issue a misspelling in the in the testimonial variable on the Building a About page will be corrected.

Action Items

  • For the file _includes/about-page/about-card-news.html, correct the spelling from "testemonial" to "testimonial", so

          {% for testemonial in site.data.internal.testimonials %}
              <div class="garcetti-quote"><div class="entire-quote"><img class="quote-marks" src="/assets/images/about/quotes.png" alt=""> 
                  <p class="quote-text"> {{testemonial.quote}}</p>
              </div>
                  <cite class="mayor-cite">&#8212; {{testemonial.source}}</cite>
                  <img id="quote-tmc" src="{{testemonial.img_url}}" alt="{{testemonial.source}}">
    

    becomes

          {% for testimonial in site.data.internal.testimonial%}
              <div class="garcetti-quote"><div class="entire-quote"><img class="quote-marks" src="/assets/images/about/quotes.png" alt=""> 
                  <p class="quote-text"> {{testimonial.quote}}</p>
              </div>
                  <cite class="mayor-cite">&#8212; {{testimonial.source}}</cite>
                  <img id="quote-tmc" src="{{testimonial.img_url}}" alt="{{testimonial.source}}">
    
  • Use Docker to test changes locally, in both desktop and mobile views

Resources

Website page with issue: https://www.hackforla.org/about/
File on GitHub: https://github.com/hackforla/website/blob/gh-pages/_includes/about-page/about-card-news.html

@essencegoff essencegoff added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: About Us https://www.hackforla.org/about/ time sensitive Needs to be worked on by a particular timeframe size: 0.25pt Can be done in 0.5 to 1.5 hours feature: spelling labels Oct 22, 2024
@essencegoff essencegoff added this to the 05. Know HFLA milestone Oct 22, 2024
@essencegoff essencegoff added time sensitive Needs to be worked on by a particular timeframe and removed time sensitive Needs to be worked on by a particular timeframe labels Oct 22, 2024
@essencegoff essencegoff changed the title Correct misspelling in Building a Survey Reporting Dashboard page Correct misspelling in About page Oct 22, 2024
@mugdhchauhan mugdhchauhan self-assigned this Nov 9, 2024
@mugdhchauhan mugdhchauhan moved this from Prioritized backlog to In progress (actively working) in P: HfLA Website: Project Board Nov 9, 2024
@HackforLABot
Copy link
Contributor

Hi @mugdhchauhan, thank you for taking up this issue! Hfla appreciates you :)

Do let fellow developers know about your:-
i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?)
ii. ETA: (When do you expect this issue to be completed?)

You're awesome!

P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :)

@mugdhchauhan
Copy link
Member

Availability for this week:

  • 9th Nov @ 6 PM - 8 PM (GMT)
  • 10th Nov @ 6 PM - 8 PM (GMT)

My estimated ETA for completing this issue:

  • 1 hour

@mugdhchauhan
Copy link
Member

mugdhchauhan commented Nov 9, 2024

Progress Report

Progress: "What is the current status of your project? What have you completed and what is left to do?"

  • Created new branch: correct-misspelling-about-page-7623
  • Corrected misspellings
  • Used Docker to test changes locally in desktop and mobile views
  • Pushed my local commits to my repository

Blockers: "Difficulties or errors encountered."

  • There are no incorrect testimonial spellings in _includes/about-page/about-card-metrics.html
  • However, I discovered incorrect testimonial spellings are present in _includes/about-page/about-card-news.html
  • I have made changes to this about-card-news.html
  • Please see pictures below

Availability: "How much time will you have this week to work on this issue?"

  • I am flexible with timing. I can be available later today or tomorrow morning and evening.
  • I'm also available 10th Nov @ 6 PM - 8 PM (GMT)

ETA: "When do you expect this issue to be completed?"

  • I have corrected testimonial spelling in _includes/about-page/about-card-news.html
  • Completed Docker test in desktop and mobile

Pictures (optional): "Add any pictures of the visual changes made to the site so far."

  • No incorrect spellings in _includes/about-page/about-card-metrics.html as shown below:
    about-card-metrics

  • Found incorrect testimonial spellings in _includes/about-page/about-card-news.html:
    about-card-news

  • My changes to this about-card-news.html:
    my-changes-code

  • Used Docker to test changes locally, in both desktop and mobile views:
    docker-test-desktop
    docker-test-mobile

@jphamtv
Copy link
Member

jphamtv commented Nov 15, 2024

Hey @mugdhchauhan - thanks for the extra effort in researching and documenting the correct file that needs to be updated. I edited the issue summary to reflect the correct file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: spelling good first issue Good for newcomers P-Feature: About Us https://www.hackforla.org/about/ role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours time sensitive Needs to be worked on by a particular timeframe
Projects
Development

Successfully merging a pull request may close this issue.

4 participants