Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Research and recommend best practice for using quotes around text in .md files #7565

Open
4 tasks
codyyjxn opened this issue Oct 5, 2024 · 10 comments
Open
4 tasks
Assignees
Labels
Complexity: Medium Draft Issue is still in the process of being created epic Feature: Standards good first issue Good for newcomers Issue Making: Level 2 Make issue(s) from an ER or Epic Ready for Prioritization role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours Status: Help Wanted Internal assistance is required to make progress

Comments

@codyyjxn
Copy link
Member

codyyjxn commented Oct 5, 2024

Overview

We need to research and recommend best practice so that we can audit the site to determine which quotes or lack of quotes need to be fixed.

Details

Here is an example of two text items in the same file.

https://github.com/hackforla/website/blob/gh-pages/.github/ISSUE_TEMPLATE/project-profile-card-review-and-update.yml?plain

Here are examples from two different project .md files. Notice that first one one uses a double quote and the second uses a single quote for the same type of link

url: "https://github.com/hackforla/food-oasis"

url: 'https://github.com/100Automations/website'

Action Items

  • Identify where quotes are required in project-profile-card-review-and-update.yml
  • Use tools or manually review to find missing or incorrect quotes.
  • Choose and stick to a consistent quote style (single or double).
  • Create simple guidelines for your team to follow.

Resources

@codyyjxn codyyjxn added good first issue Good for newcomers role: front end Tasks for front end developers Complexity: Medium epic size: 0.25pt Can be done in 0.5 to 1.5 hours Issue Making: Level 2 Make issue(s) from an ER or Epic labels Oct 5, 2024
@github-project-automation github-project-automation bot moved this to New Issue Approval in P: HfLA Website: Project Board Oct 5, 2024
@HackforLABot HackforLABot added the Feature Missing This label means that the issue needs to be linked to a precise feature label. label Oct 5, 2024

This comment was marked as outdated.

@codyyjxn codyyjxn added Feature: Standards and removed Feature Missing This label means that the issue needs to be linked to a precise feature label. labels Oct 5, 2024
@codyyjxn codyyjxn changed the title EPIC: Create issues so that we correctly use quotes around text in .md files ER: Create issues so that we correctly use quotes around text in .md files Oct 5, 2024
@codyyjxn codyyjxn added the ready for merge team needs a senior review either to do some re writing or to approve it for ready for prioritization label Oct 5, 2024
@codyyjxn codyyjxn moved this from New Issue Approval to Questions / In Review in P: HfLA Website: Project Board Oct 5, 2024
@ExperimentsInHonesty

This comment was marked as duplicate.

@ExperimentsInHonesty

This comment was marked as outdated.

@ExperimentsInHonesty ExperimentsInHonesty added Draft Issue is still in the process of being created and removed ready for merge team needs a senior review either to do some re writing or to approve it for ready for prioritization labels Oct 6, 2024
@ExperimentsInHonesty ExperimentsInHonesty added this to the x. Technical debt milestone Oct 6, 2024
@HackforLABot

This comment was marked as outdated.

@HackforLABot

This comment was marked as outdated.

@ExperimentsInHonesty ExperimentsInHonesty changed the title ER: Create issues so that we correctly use quotes around text in .md files Create issues so that we correctly use quotes around text in .md files Oct 25, 2024
@ExperimentsInHonesty ExperimentsInHonesty changed the title Create issues so that we correctly use quotes around text in .md files research and recommend best practice for using quotes around text in .md files Oct 25, 2024
@ExperimentsInHonesty ExperimentsInHonesty changed the title research and recommend best practice for using quotes around text in .md files Research and recommend best practice for using quotes around text in .md files Oct 25, 2024
@ExperimentsInHonesty
Copy link
Member

ExperimentsInHonesty commented Oct 25, 2024

@codyyjxn

@codyyjxn codyyjxn added the ready for dev lead Issues that tech leads or merge team members need to follow up on label Oct 25, 2024
@codyyjxn codyyjxn moved this from New Issue Approval to Prioritized backlog in P: HfLA Website: Project Board Oct 25, 2024
@codyyjxn codyyjxn moved this from Prioritized backlog to New Issue Approval in P: HfLA Website: Project Board Oct 25, 2024
@ExperimentsInHonesty
Copy link
Member

@codyyjxn I think you missed what you were supposed to do for this issue.

  1. write this issue so that it has action items that achieve the scope listed in the overview

We need to research and recommend best practice so that we can audit the site to determine which quotes or lack of quotes need to be fixed.

The current draft of the action items, tell the person to make the changes, which is premature given that no one has done the research and recommendations yet. I am not asking you to do the research and recommendations, but rather write an issue for someone to do it.

@ExperimentsInHonesty ExperimentsInHonesty removed Ready for Prioritization ready for dev lead Issues that tech leads or merge team members need to follow up on labels Oct 30, 2024
@codyyjxn
Copy link
Member Author

codyyjxn commented Nov 3, 2024

@codyyjxn I think you missed what you were supposed to do for this issue.

  1. write this issue so that it has action items that achieve the scope listed in the overview

We need to research and recommend best practice so that we can audit the site to determine which quotes or lack of quotes need to be fixed.

The current draft of the action items, tell the person to make the changes, which is premature given that no one has done the research and recommendations yet. I am not asking you to do the research and recommendations, but rather write an issue for someone to do it.

Got it! Thank you Bonnie!

@codyyjxn
Copy link
Member Author

@bonniewolfe Hi bonnie I have changed the instructions. I will attend todays meeting as well.

@codyyjxn
Copy link
Member Author

@bonniewolfe How can I get some more guidance on this ?

@codyyjxn codyyjxn added the Status: Help Wanted Internal assistance is required to make progress label Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Medium Draft Issue is still in the process of being created epic Feature: Standards good first issue Good for newcomers Issue Making: Level 2 Make issue(s) from an ER or Epic Ready for Prioritization role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours Status: Help Wanted Internal assistance is required to make progress
Projects
Status: New Issue Approval
Development

No branches or pull requests

3 participants