Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Pre-work checklist template #4944

Open
1 of 6 tasks
roslynwythe opened this issue Jul 13, 2023 · 44 comments
Open
1 of 6 tasks

Update Pre-work checklist template #4944

roslynwythe opened this issue Jul 13, 2023 · 44 comments
Assignees
Labels
Complexity: Large epic Feature: Onboarding/Contributing.md role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 1pt Can be done in 4-6 hours

Comments

@roslynwythe
Copy link
Member

roslynwythe commented Jul 13, 2023

Prerequisite

  1. Be a member of Hack for LA. (There are no fees to join.) If you have not joined yet, please follow the steps on our Getting Started page and attend an onboarding session.
  2. Please make sure you have read our Hack for LA Contributing Guide before you claim/start working on an issue.

Overview

We need to update the prework checklist issue to provide current and relevant information to junior developers.

Action Items

  • Navigate to .github/ISSUE_TEMPLATE/pre-work-template--dev.md
  • Replace the contents with the text provided in the Resources/Issue Template Text section below
  • Test the updated template using these instructions. Copy the contents of that comment into a new comment in this issue, and check off the boxes as you complete the steps.

For PR Reviewers and Merge Team
To review this issue, click the link below under "Link for reviewers" and verify that the labels match the updated labels string in the issue.

Link for Reviewers
This URL will be inserted by the dev during the test process and will be used by reviewers to preview the updated template.
URL of the issue branch on the test Repository: [REPLACE THIS TEXT AND BRACKETS WITH THE URL]

For PM, Merge Team, or Tech Lead

  • Once the pull request associated with this issue is approved and merged, please update and edit epic Creating issues to Add Missing Labels to Issue Templates #4307 by
    • Checking off the dependency for this issue
    • If all dependencies are checked off, please move issue to the New Issue Approval column and remove the Dependency label

Resources

Issue Template Text
### Prerequisite
We are looking forward to having you on our team. Please make sure to attend the general Hack for LA onboarding to get the process started https://meetup.com/hackforla/events.

### Overview
As a new developer on the HfLA website team, fill in the following fields as you complete each onboarding item.

### Special Notes
 
1. Usually we don't want to you have more than one issue assigned to you at a time, this issue is the exception, because it is instructions on how to work on other issues.  Do not close this issue. 
2. The action items listed below should mostly be worked on in a sequential order. However, you don't have to wait on one if you can proceed with the others, For instance, you don't have to wait for attending a weekly meeting before setting up your dev environment.  

### Action Items

- [ ] To find contact information for the merge team members and technical leads, please take a look at our [Meet the Team wiki page](https://github.com/hackforla/website/wiki/Meet-the-Team)
- [ ] Register for Zoom meetings using the form at [NEED TO FILL IN THE URL TO ZOOM REG FORM]
- [ ]  If you have not done so already, add yourself to the [team roster](https://docs.google.com/spreadsheets/d/11u71eT-rZTKvVP8Yj_1rKxf2V45GCaFz4AXA7tS_asM/edit#gid=0)
- [ ] Self Assign this issue (gear in right side panel).  
    - [ ] If there are no gears in the right side panel, contact a merge team member or technical lead and ask them to check your membership in the `website-write` and `website` teams on GitHub.
- [ ] Add the "role: front end" or "role: back end" or both label(s) to this issue and remove the "role missing" label (gear in right side panel)
- [ ] Add this issue to the Project Board under the Projects section (gear in right side panel)
- [ ] Signup for a [Figma](https://Figma.com) account
- [ ] Attend weekly team meetings:
  - [ ] Developer (front-end/back-end) weekly team meeting, Tuesdays 7-8pm PST
  - [ ] (Optional) Office Hours, Thursdays 7-8pm PST
  - [ ] All team meeting (UX, Development, Product), Sunday 10am-12pm PST
- [ ] Note: There are no meetings on the 1st-7th of every month.
- [ ] Note regarding weekly team meeting requirements: All website team members are required to attend at least 1 team meeting in a week (held on Tuesdays, Thursdays and Sundays). In case, you are unable in any given week, you should reach out to the tech leadership team. Exceptions to this requirement may be provided on a case-by-case basis. Also, please let the tech leadership team know (through a slack message in the hfla-site channel as well as an @ mention in a comment of the issue that you would be working on) if you are planning to take a week off or a longer vacation.
- [ ] Complete steps 1.1 - 1.6 in [Part 1: Setting up the development environment within Contributing.md](https://github.com/hackforla/website/blob/gh-pages/CONTRIBUTING.md#part-1-setting-up-the-development-environment)
  - [ ] OPTIONAL: If you run into any issues, use [4.1 How do I ask for help within Contributing.md](https://github.com/hackforla/website/blob/gh-pages/CONTRIBUTING.md#41-what-do-i-do-if-i-need-help) as a visual example to get a hold of our [HfLA website leadership team](https://github.com/hackforla/website/projects/7#card-69730135). That way we can help you resolve any set up issues immediately.
- [ ] Read section 2.1 - 2.4 in [Part 2: How the Website team works with GitHub issues within Contributing.md](https://github.com/hackforla/website/blob/gh-pages/CONTRIBUTING.md#part-2-how-the-website-team-works-with-github-issues)
  - [ ] Follow the steps in section [2.3 Where can I find GitHub issues to work on?](https://github.com/hackforla/website/blob/gh-pages/CONTRIBUTING.md#23-where-can-i-find-github-issues-to-work-on) to assign yourself your first issue under the Project Board's Prioritized Backlog column and use [2.7 Working on a Issue within Contributing.md](https://github.com/hackforla/website/blob/gh-pages/CONTRIBUTING.md#27-working-on-an-issue) to start working on your issue
  - [ ] Read [2.6 What to do when you need to stop mid issue](https://github.com/hackforla/website/blob/gh-pages/CONTRIBUTING.md#26-what-to-do-when-you-need-to-stop-mid-issue)
- [ ] Once you take a good first issue, you will provide estimates and progress reports. Also, once you finish providing your "Estimate" action item below, please answer the question in the "Time spent so far" action item (also below).
   - [ ] Estimate: Copy the below and put it in the "good first issue" that you picked.
 Check this box when you have completed this task so that we can identify if you understood the instructions and know what to do on all subsequent issues upon assignment. (Note: Please provide estimates on all the issues that you pick up, going forward.)
    ```
   Availability for this week:
   My estimated ETA for completing this issue:
    ```
   - [ ] Time spent so far: Copy the question below into a new comment below (in this pre-work issue only) and answer it. This is just to get feedback on how long it took you to get to this point on this pre-work. There is no right or wrong answers. There is no judgement. It is ok if you take a long time or if you do it really fast or at any pace.
    ```
    How many hours did it take you to finish the pre-work up to and including adding your initial ETA and availability for your good first issue, including attending your first meetings?
    ```
   - [ ] Progress Reports: Copy the below and put it in the issue once you have been assigned to the issue at least 5 days (we check weekly on Fridays), or sooner if you have something to report.  If you finish this issue before 5 days are reached, Yeah!!, do it on your next issue. **This update should be done every week for every issue that you are assigned to**. The checkbox here is meant for us to see if you understood the instructions when you end up doing your first weekly progress update.
    ```
    Provide Update
    1. Progress
    2. Blockers
    3. Availability
    4. ETA
    ```
- [ ] Read sections 3.1.a - 3.1.c in [3.1 How to make a pull request](https://github.com/hackforla/website/blob/2e3c45fede99e61f479548ccca3f0dda83e351db/CONTRIBUTING.md#31-how-to-make-a-pull-request) to learn more about how to make a pull request (PR) for the issue that you are working on and how to make changes to your PR if changes are requested by the reviewer
- [ ] Additional notes:
   - [ ] Please don't forget to review pull requests whenever you are able to.  The [How to review Pull Requests](https://github.com/hackforla/website/wiki/How-to-review-pull-requests) guide will teach you how to review pull requests.
   - [ ] Please work on only one issue at a time and wait until your pull request is merged before picking up another issue.
- [ ] Read and understand how we progress through issues. Then, you can check this off.
Progress through issues in the [prioritized backlog](https://github.com/hackforla/website/projects/7#column-7198257) only with increasing complexity in the following order:
  - Good first issue (two per person)
  - Small (one per person, with some exceptions, see below)
  - Medium (one per person, with some exceptions, see below) 
  - Large (you can work on more than one large issue, but only one at a time)
    - The reasons for this progression are:
      - The issues start out as being prescriptive and become less so as you gain more experience by working through increasingly complex issues.
      - We are trying to teach you the team methodology through the issues themselves.
      - It ensures you understand what we expect and the quality of contributions.
    - You can work on back-to-back small issues if it meets the following criteria:
      - You are learning something new and need to work on an issue of a lesser complexity
      - Special request by a lead or pm
    - You can work on a second medium issue if it meets the following criteria:
      - You are learning something new and need to work on an issue of a lesser complexity
      - Special request by a lead or pm
- [ ] Read the [Start Here - Developers](https://www.figma.com/file/0RRPy1Ph7HafI3qOITg0Mr/Hack-for-LA-Website?node-id=8583%3A0) in Figma
- [ ] Go familiarize yourself with the [Hack for LA Design System page in Figma](https://www.figma.com/file/0RRPy1Ph7HafI3qOITg0Mr/Hack-for-LA-Website?node-id=3464%3A3)  (where you can see components and their SCSS classes)


### What should I do if I have a question about an issue I'm working on, and I haven't gotten a response yet?
- First, you should post the question or blocker as a comment on your assigned issue, so it can be easily referred to in the next bullet points.
- Then, add the label "Status: Help Wanted" so other developers can see it and potentially help answer your question. In addition, you will still need to post a Slack message or bring it up in meeting so we know you need help; see below for how to do that.
- Also, you can post your question on the hfla-site slack channel and link the issue you're working on, so other developers can see and respond.
- Lastly, you can add the issue to the "Questions/In Review" column of the Project Board so that it can be addressed in the next development meeting. Please bring it during the meeting that you need help.

### Resources/Instructions
- [Contributing.md - Hack for LA](https://github.com/hackforla/website/blob/gh-pages/CONTRIBUTING.md)
- [GitHub Project Board - Hack for LA](https://github.com/hackforla/website/projects/7)
- [GitHub Project Board Prioritized Backlog highlighted and sorted by Front End](https://github.com/hackforla/website/projects/7?card_filter_query=label%3A%22role%3A+front+end%22)
- [GitHub Project Board Prioritized Backlog highlighted and sorted by Back End/DevOps](https://github.com/hackforla/website/projects/7?card_filter_query=label%3A%22role%3A+back+end%2Fdevops%22)
- [Figma - Hack for LA](https://www.figma.com/file/0RRPy1Ph7HafI3qOITg0Mr/Hack-for-LA-Website)
- [Google Drive - Hack for LA website team](https://drive.google.com/drive/folders/1p76K0FgfiAWeIIEyoyJ_Iik8FVj8cBjT?usp=sharing)
- [Agenda / Notes - Dev Team Tuesday meeting](https://github.com/hackforla/website/issues/2010)
- [Agenda / Notes - All Team meeting](https://github.com/hackforla/website/issues/2027)
- [How to review Pull Requests](https://github.com/hackforla/website/wiki/How-to-review-pull-requests)
@roslynwythe roslynwythe added Feature: Onboarding/Contributing.md role missing size: 1pt Can be done in 4-6 hours Complexity: Prework prework role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers Complexity: Small Take this type of issues after the successful merge of your second good first issue ready for product Draft Issue is still in the process of being created and removed Complexity: Prework prework role missing ready for product labels Jul 13, 2023
@roslynwythe

This comment was marked as outdated.

@roslynwythe roslynwythe added ready for product and removed Draft Issue is still in the process of being created prework labels Jul 13, 2023
@ExperimentsInHonesty

This comment was marked as outdated.

@ExperimentsInHonesty
Copy link
Member

ExperimentsInHonesty commented Nov 14, 2023

This link but added to the project board, would show anyone who needs to write issues, which ERs are ready for that
ISSUE Tab
Project Board

@ExperimentsInHonesty
Copy link
Member

ExperimentsInHonesty commented Mar 13, 2024

@roslynwythe

I am still working on this draft, but this is what I accomplished on the plane. Additional items I plan to incorporate

  • finish the issue ladder
  • add in making issues
  • have them express interest in joining the merge team at a specific spot
  • have them check off items on self assessment
    • at onset
    • ongoing
Details

Bonnie's Draft -WIP. Will tell you when I am done

Prerequisite

We are looking forward to having you on our team. Please make sure to attend the general Hack for LA onboarding to get the process started https://meetup.com/hackforla/events.

Overview

As a developer on the website team this issue will be your companion and a place to track your progress with the path we have set out for you.

Special Notes

  1. This issue will stay open for as long as you are on the Website team. Use it as a place to indicate that you have completed a level as well as get instructions on how to progress.
  2. Usually we don't want to you have more than one issue assigned to you at a time, this issue is the exception, because it is instructions on how to work on other issues. Do not close this issue until you leave the team (see todo items associated with leaving professionally)
  3. The action items listed below should mostly be worked on in a sequential order. However, you don't have to wait on one if you can proceed with the others, For instance, you don't have to wait for attending a weekly meeting before setting up your dev environment.
  4. During the General Hack for LA onboarding, you will be directed to fill out a form that will add you to the website team roster, google drive and GitHub teams. If you have not done that yet, you will not be able to do the action items in section 1.0
    • [WE NEED TO WRITE AN AUTOMATION THAT ADDS PEOPLE TO THE ROSTER AUTOMATICALLY]

Action Items

1.0 JOINING THE WEBSITE TEAM.

  • Self Assign this issue (gear in right side panel).
    • If there are no gears in the right side panel, contact a merge team member or technical lead and ask them to check your membership in the website-write and website teams on GitHub.
  • Add yourself to the #hfla-site and #hfla-site-pr Slack channels
  • Register for Zoom meetings using the form at [NEED TO FILL IN THE URL TO ZOOM REG FORM]
  • Add the "role: front end" or "role: back end" or both label(s) to this issue and remove the "role missing" label (gear in right side panel)
  • Add this issue to the Project Board under the Projects section (gear in right side panel)
  • Signup for a Figma account
  • Post the following message in a comment below on this issue and then answer it.
    ### 1.0 JOINING THE WEBSITE TEAM update
    >How many hours did it take you to finish this step?
    

2.0 TEAM MEETINGS

  • Attend weekly team meetings:
    • Developer (front-end/back-end) weekly team meeting, Tuesdays 7-8pm PST
    • (Optional) Office Hours, Thursdays 7-8pm PST
    • All team meeting (UX, Development, Product), Sunday 10am-12pm PST
  • Note: The meetings the the 1st-7th of every month are plannign meetings for leads and merge team You are welcome to observe but we don't provide team member support.
  • Note regarding weekly team meeting requirements: All website team members are required to attend at least 1 team meeting in a week (held on Tuesdays, Thursdays and Sundays). In case, you are unable in any given week, you should reach out to the tech leadership team. Exceptions to this requirement may be provided on a case-by-case basis. Also, please let the tech leadership team know (through a slack message in the hfla-site channel as well as an @ mention in a comment of the issue that you would be working on) if you are planning to take a week off or a longer vacation.
  • Post the following message in a comment below on this issue and then answer it.
    ### 2.0 TEAM MEETINGS update
    >which meetings did you register for
     - [ ] Developer (front-end/back-end)
     - [ ] (Optional) Office Hours
     - [ ] All team meeting 
    >When did you attend your first team meeting?
    
    

3.0 GETTING YOUR DEVELOPMENT ENVIRONMENT SETUP

  • Complete steps 1.1 - 1.6 in Part 1: Setting up the development environment within Contributing.md
  • Post the following message in a comment below on this issue and then answer it. While keeping in mind that this is just to get feedback on how long it took you to get to this point. There is no right or wrong answers. There is no judgement. It is ok if you take a long time or if you do it really fast or at any pace. Getting your dev enviorment setup will be easier for some people because they might already have some experience or items installed on their computer and you may not. This is an important step, be patient with yourself and your computer but keep on it till you get it done.
    ### 3.0 GETTING YOUR DEVELOPMENT ENVIRONMENT SETUP update
    >How many hours did it take you to finish this step?
    

4.0 FINDING AN ASSIGNING YOUR FIRST GITHUB ISSUE

  • Read section 2.1 - 2.4 in Part 2: How the Website team works with GitHub issues within Contributing.md

  • Once you self assign an issue, an automation will post a welcome meesage in a comment giving you additional guidance on to manage your issue (includes how to provide estimates and progress reports there).

    • On assignment, you will be prompted to estimate Availability and ETA. Once you have done that on your good first issue, check this box on this issue to let us know you have completed that task and understand how to do it in future. If you hae any questions about estimating the issue you choose, please add them to the issue, put the issue in the questions/review column, and add the label ready for dev lead and help wanted

      Availability for this week:

      My estimated ETA for completing this issue:

  • Post the following message in a comment below on this issue and then answer it.

    ### 4.0 FINDING AN ASSIGNING YOUR FIRST GITHUB ISSUE update
    >How many hours did it take you to finish this step?
    

    5.0 GIVING WEEKLY UPDATES ON YOUR DEVELOPMENTT ISSUES

    • Progress Reports: Copy the below and put it in the issue once you have been assigned to the issue at least 5 days (we check weekly on Fridays), or sooner if you have something to report. If you finish this issue before 5 days are reached, Yeah!!, do it on your next issue. This update should be done every week for every issue that you are assigned to. The checkbox here is meant for us to see if you understood the instructions when you end up doing your first weekly progress update.
    Provide Update
    1. Progress
    2. Blockers
    3. Availability
    4. ETA
    
    • Post the following message in a comment below on this issue and then answer it.
    ### 5.0 GIVING WEEKLY UPDATES ON YOUR DEVELOPMENTT ISSUES update
    >on what issue did you give your first weekly update?
    - #
    

6.0 PULL REQUESTS

  • Read sections 3.1.a - 3.1.c in 3.1 How to make a pull request to learn more about how to make a pull request (PR) for the issue that you are working on and how to make changes to your PR if changes are requested by the reviewer
  • Additional notes:
    • Please don't forget to review pull requests whenever you are able to. The How to review Pull Requests guide will teach you how to review pull requests.
    • Please work on only one issue at a time and wait until your pull request is merged before picking up another issue.
    • Once your pull request has been accepted, post the following message in a comment below on this issue and then answer it.
      ### 6.0 PULL REQUESTS update
      >Did you receive any reviews that required you to change anything on your PR? 
      - [ ] no
      - [ ] yes (if yes, describe what you learned)
      >Wwhat is the number of your first merged pull request?
      - #
      

7.0 ADVANCED READING TO READY YOU FOR LARGER MORE COMPLEX ISSUES

  • Read the Start Here - Developers in Figma
  • Go familiarize yourself with the Hack for LA Design System page in Figma (where you can see components and their SCSS classes)
  • Post the following message in a comment below on this issue and then answer it.
    ### 7.0 ADVANCED READING TO READY YOU FOR LARGER MORE COMPLEXT ISSUESupdate
    >How many hours did it take you to finish this step?
    >Do you have any questions about what you read?
       - [ ] yes, I had questions, and I left comments in the approatte issues [WE NEED TO UPDATE THOSE TWO RESROUCES TO HAVE LINKS TO ISSUES WHERE PEOPLE CAN PUT QUESTIONS AND MOVE THE ISSUES TO THE QUESTIONS/REVIEW COLUMN]
       - [ ] no, I did not have any questions
    

8.0 MOVE ON TO 2ND GOOD FIRST ISSUE (AKA, IT GETS EASIER AND DID YOU BRANCH CORRECTLY?)

  • Do another Good first issue (two per person total). We have you do another simple issue becaues this we want you to
    • see the difference once you have sucessfull setup your dev enviornment
    • see how each PR gets eaiser to do with repetion
    • make sure you know how to branch propertly (most problems show up in the second commit)
  • Once your pull request has been accepted, post the following message in a comment below on this issue and then answer it.
    ### 8.0 MOVE ON TO 2ND GOOD FIRST ISSUE update
    >Did you receive any reviews that required you to change anything on your PR? 
    - [ ] no
    - [ ] yes (if yes, describe what you learned)
    >Wwhat is the number of your 2nd merged pull request?
    - #
    

9.0 UUNDERSTAND HOW TO PROGRESS THROUGH ISSUES IN THE PRIOIRTIZED BACKLOG AND ON ISSUE MAKING AND TEMPER CHECK

Congrats on making it this far. Issues get more complicated from here, either they include more changes, or have several files to change or you have to research something that we are unsure how to do, or there is complicated logic that needs writing or rewriting. Each issue size that you take on will guide you to a more complicated level in sequence, and you can see from the labels and overviews what they are about.

Its important that you try to work on issues that fill in gaps in your knowlege (see the self test for a reminder about what to look for).

So keep going, the fun stuff is about to start.

Having said that, we are also going to have you take on some issue making (sadly there is no issue making fairy). so pay attention to how the issues you have already worked on are constructed and how they change as they go up the ladder. That way when we start you on the isusue making portion of the team work, you will know what you are shooting for when its your time to make issues.

Also, we want you on the Merge team. This will ensure you are a competent developer and an awsome collaborative contributor to any team you join in the future.

  • Let us know that you have re-reviewed your issues, have read the above and are continuing on the team
    ### 9.0 UUNDERSTAND HOW TO PROGRESS THROUGH ISSUES IN THE PRIOIRTIZED BACKLOG AND ON ISSUE MAKING update
    >Did you receive any reviews that required you to change anything on your PR? 
    - [ ] Im am so ready, bring it on (continuing)
    - [ ] I am worn out from the setup and the good first issues but still game (continuing)
    - [ ] I won't be continuing, (please let us know why in a comment and close this issue)
    
    

[THIS WHOLE THING COULD BE MOVED TO A WIKI PAGE THAT EXPLAINS THE VALUE TO THEIR CAREER AND HAVE A TLDR HERE]

10.0 SMALL

prioritized backlog
[CHANGE THIS LINK TO JUST HAVE SMALL ISSUES]

  • Assign youself a small issue
  • Submit your PR.
  • While you are waiting for your PR to be reviewed, please review other peoples good first issues.
  • Once your pull request has been merged post the following message in a comment below on this issue and then answer it.
    ### 10.0 SMALL update
    >Did you receive any reviews that required you to change anything on your PR? 
    - [ ] no
    - [ ] yes (if yes, describe what you learned)
    >Wwhat is the number of your small merged pull request?
    - #
    >Did you review any good first issue PRs?
    - [ ] no
    - [ ] yes
      - if yes, what were the numbers
        - #
        - #
        Did you catch anything?
        - [ ] yes
        - [ ] no
          - if you did't catch anything, did anyone else who reviewed it after you, catch anything?
            - [ ] no
            - [ ] yes
               - if yes, descrube what you learned?
    

11.0 Medium

prioritized backlog
[CHANGE THIS LINK TO MEDIUM SIZE ISSUES]

  • Assign youself a medium issue
  • Submit your PR.
  • While you are waiting for your PR to be reviewed, please review other peoples good small issues
  • Once your pull request has been merged, post the following message in a comment below on this issue and then answer it.
    ### 11.0 MEDIUM update
    >Did you receive any reviews that required you to change anything on your PR? 
    - [ ] no
    - [ ] yes (if yes, describe what you learned)
    >Wwhat is the number of your medium merged pull request?
    - #
    >Did you review any small issue PRs?
    - [ ] no
    - [ ] yes
      - if yes, what were the numbers
        - #
        - #
        Did you catch anything?
        - [ ] yes
        - [ ] no
          - if you did't catch anything, did anyone else who reviewed it after you, catch anything?
            - [ ] no
            - [ ] yes
               - if yes, descrube what you learned?
    

12.0 LARGE

prioritized backlog
[CHANGE THIS LINK TO LARGE SIZE ISSUES]

  • Assign youself a large issue

  • Submit your PR.

  • While you are waiting for your PR to be reviewed, please review other peoples medium issues

  • Once your pull request has been merged, post the following message in a comment below on this issue and then answer it.

    ### 12.0 LARGE update
    >Did you receive any reviews that required you to change anything on your PR? 
    - [ ] no
    - [ ] yes (if yes, describe what you learned)
    >Wwhat is the number of your large merged pull request?
    - #
    >Did you review any medium issue PRs?
    - [ ] no
    - [ ] yes
      - if yes, what were the numbers
        - #
        - #
        Did you catch anything?
        - [ ] yes
        - [ ] no
          - if you did't catch anything, did anyone else who reviewed it after you, catch anything?
            - [ ] no
            - [ ] yes
               - if yes, descrube what you learned?
    
    • Medium (you can work on one medium issue, but only one at a timeone per person, with some exceptions, see below)
    • Large (you can work on more than one large issue, but only one at a time)
      • The reasons for this progression are:
        • The issues start out as being prescriptive and become less so as you gain more experience by working through increasingly complex issues.
        • We are trying to teach you the team methodology through the issues themselves.
        • It ensures you understand what we expect and the quality of contributions.
      • You can work on back-to-back small issues if it meets the following criteria:
        • You are learning something new and need to work on an issue of a lesser complexity
        • Since we have a limited number of these, you must get approval from lead or pm
      • You can work on a second medium issue if it meets the following criteria:
        • You are learning something new and need to work on an issue of a lesser complexity
        • Since we have a limited number of these, you must get approval from lead or pm

What should I do if I have a question about an issue I'm working on, and I haven't gotten a response yet?

  • First, you should post the question or blocker as a comment on your assigned issue, so it can be easily referred to in the next bullet points.
  • Then, add the label "Status: Help Wanted" so other developers can see it and potentially help answer your question. In addition, you will still need to post a Slack message or bring it up in meeting so we know you need help; see below for how to do that.
  • Also, you can post your question on the hfla-site slack channel and link the issue you're working on, so other developers can see and respond.
  • Lastly, you can add the issue to the "Development team meeting discussion items" "Questions/In Review" column of the Project Board so that it can be addressed in the next development meeting. Please bring it during the meeting that you need help.

Resources/Instructions

@ExperimentsInHonesty

This comment was marked as outdated.

@ExperimentsInHonesty
Copy link
Member

ExperimentsInHonesty commented Oct 15, 2024

change the prework so that it says, if there are no PRs to review, leave the following comment

There are no GFI PRs to review.

add the label need PRs to review: GFI
then move on, and circle back frequently, checking to see if there are PRs to review so you can check the boxes off and give your update


@ExperimentsInHonesty
Copy link
Member

section 13 and possibly other places: Mention that if the issue calls for a different ready for label, use the one in the issue

@ExperimentsInHonesty
Copy link
Member

also in section 13 its says " These new issues will end up in the new issue approval column with the label ready for merge team" this makes it sound like the label will be added automagically. The automation will add the issue to the board and the column, but it won't add the label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Large epic Feature: Onboarding/Contributing.md role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 1pt Can be done in 4-6 hours
Projects
Status: In progress (actively working)
Development

No branches or pull requests

5 participants