Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug that prevents GHA "Schedule Thursday 1100" from running #4768

Closed
11 of 12 tasks
t-will-gillis opened this issue Jun 1, 2023 · 12 comments · Fixed by #5158
Closed
11 of 12 tasks

Fix bug that prevents GHA "Schedule Thursday 1100" from running #4768

t-will-gillis opened this issue Jun 1, 2023 · 12 comments · Fixed by #5158
Assignees
Labels
Bug Something isn't working Complexity: Large Feature: Board/GitHub Maintenance Project board maintenance that we have to do repeatedly Feature: Refactor GHA Refactoring GitHub actions to fit latest architectural norms role: back end/devOps Tasks for back-end developers size: 3pt Can be done in 13-18 hours time sensitive Needs to be worked on by a particular timeframe

Comments

@t-will-gillis
Copy link
Member

t-will-gillis commented Jun 1, 2023

Prerequisite

  • You must be a member of Hack for LA. If you have not joined yet, please follow the steps on our Getting Started page.
  • Please make sure you have read our Hack for LA Contributing Guide before you claim/start working on an issue.

Overview

We need our GitHub actions to run on the schedule we set so that we can continue to maintain our workflow. For over a year the GHA "Schedule Thursday 1100" has failed before completion, and the source(s) of the error need to be addressed.

Details

NOTE: the "Schedule Thursday 1100" triggers the GHA trim-contributors action and contributors-data.js. It appears that this file looks for inactive members and removes them from the "website" and/or "website-write" teams.

When reviewing HfLA "Actions" logs on the repo, it can be seen that the GHA "Schedule Thursday 1100" was been running weekly for almost a year. For the first Thursday of the month, the GHA fails. For the remaining Thursday, the GHA runs successfully because it is setting up the trim-contributors job, however that job is only scheduled to run on the first Thursday. In other words, these runs are unnecessary.

Also, the paths on current Lines 38 and 45 are incorrect and need to be refactored.

Action Items

  • The schedule-thu-1100.yml needs to be refactored so that the trim-contributors job is only being initiated on the first day of the month, and not every Thursday as it is currently.
  • Delete the "Get current date" step from the .yml file. (There is a warning in the logs noting that the "set-output" command in the step "Get current date" is deprecated.)
  • Done On the yml file, change versions: line 24 to actions/checkout@v3 per PR 4735 and line 30 to actions/setup-node@v3 per PR 4739
  • The working-directory in the step "Install npm dependencies" needs to be refactored to the correct directory- i.e. /github-data/. (ref PR 3359).
  • The run path as shown in the step "Trim Members" needs to be refactored to the correct path to contributors-data.js.
  • Lines 1 and 2 of contibutors-data.js are referring to modules in the package.json file and currently can't be found. To address this, either:
    • Refactor the paths to @octokit/rest and true-github-contributors or if this isn't possible
    • Move contributors.js to the /github-data/ folder- and a.) remove the now empty /trim-contributors/ folder and b.) adjust the path in the .yml accordingly.
  • Test the action on your own Project Board using on: workflow_dispatch.
  • When this issue is merged, create new issue to add this GHA to the wiki. Please refer to How to Contribute to the Wiki for instructions about where to place "Content to be Added/Edited in the New website-wiki Repo."

Merge Team/ Leads:

  • Done When this issue is merged, can immediately approve and merge Bump actions/setup-node from 2 to 3 #4739 (if testing fixes bug on the GHA with the new version number, this is evidence that changing the version number is acceptable)
  • Done The trim-contributors job is the only one running in schedule-thu-1100.yml, and it is running only once a month. Should the job move to schedule-monthly.yml? Answer is yes, this job is moved to schedule-monthly.yml

Resources/Instructions

Additional Resources

@t-will-gillis t-will-gillis added Bug Something isn't working role: back end/devOps Tasks for back-end developers Complexity: Medium Feature: Board/GitHub Maintenance Project board maintenance that we have to do repeatedly size: 2pt Can be done in 7-12 hours Draft Issue is still in the process of being created labels Jun 1, 2023
@t-will-gillis t-will-gillis changed the title Fix Bug with GHA "Schedule Thursday 1100"- not running Fix bug that prevents GHA "Schedule Thursday 1100" from running Jun 1, 2023
@t-will-gillis t-will-gillis added Complexity: Large Ready for Prioritization and removed Complexity: Medium Draft Issue is still in the process of being created labels Jun 1, 2023
@t-will-gillis t-will-gillis self-assigned this Jun 3, 2023
@github-actions

This comment was marked as outdated.

@t-will-gillis t-will-gillis added Draft Issue is still in the process of being created and removed Ready for Prioritization labels Jun 3, 2023
@t-will-gillis t-will-gillis removed their assignment Jun 3, 2023
@ExperimentsInHonesty ExperimentsInHonesty added this to the 08. Team workflow milestone Jun 4, 2023
@t-will-gillis t-will-gillis added Ready for Prioritization Feature: Refactor GHA Refactoring GitHub actions to fit latest architectural norms size: 3pt Can be done in 13-18 hours and removed Draft Issue is still in the process of being created size: 2pt Can be done in 7-12 hours labels Jun 4, 2023
@ExperimentsInHonesty ExperimentsInHonesty added time sensitive Needs to be worked on by a particular timeframe and removed Ready for Prioritization labels Jun 11, 2023
@ronaldpaek ronaldpaek self-assigned this Jun 21, 2023
@github-actions

This comment was marked as outdated.

@ronaldpaek

This comment was marked as outdated.

@ronaldpaek

This comment was marked as outdated.

@t-will-gillis

This comment was marked as outdated.

@ronaldpaek

This comment was marked as outdated.

@ronaldpaek ronaldpaek removed their assignment Jul 3, 2023
@ronaldpaek

This comment was marked as outdated.

@t-will-gillis t-will-gillis added the Draft Issue is still in the process of being created label Jul 3, 2023
@t-will-gillis

This comment was marked as outdated.

@t-will-gillis t-will-gillis removed the Draft Issue is still in the process of being created label Jul 5, 2023
@t-will-gillis t-will-gillis added the Draft Issue is still in the process of being created label Jul 23, 2023
@ExperimentsInHonesty
Copy link
Member

ExperimentsInHonesty commented Jul 25, 2023

Text for message

$assignee Our team bot has determined that you have not been active in the last 30 days. You have been unassigned from all other issues and we are going to go ahead and close this issue and remove you from the write team.

If this is a mistake or you would like return to the Hack for LA website team

  1. please respond in a comment with one of the two following messages

Our bot made a mistake, let us know

I have been active!  See Issue # or PR # 

I want to come back to the team

Please add me back to the write team, I am ready to work on an issue now.

If its been less than 20 days

  1. reopen this issue
  2. move issue to in progress
  3. make sure you are assigned to issue

If its been more than 20 days

  1. please send us a slack message with a link to your comment.

@ronaldpaek

This comment was marked as resolved.

@t-will-gillis

This comment was marked as resolved.

@t-will-gillis t-will-gillis removed the Draft Issue is still in the process of being created label Aug 7, 2023
@t-will-gillis t-will-gillis self-assigned this Aug 7, 2023
@github-actions
Copy link

github-actions bot commented Aug 7, 2023

Hi @t-will-gillis, thank you for taking up this issue! Hfla appreciates you :)

Do let fellow developers know about your:-
i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?)
ii. ETA: (When do you expect this issue to be completed?)

You're awesome!

P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Complexity: Large Feature: Board/GitHub Maintenance Project board maintenance that we have to do repeatedly Feature: Refactor GHA Refactoring GitHub actions to fit latest architectural norms role: back end/devOps Tasks for back-end developers size: 3pt Can be done in 13-18 hours time sensitive Needs to be worked on by a particular timeframe
Projects
Development

Successfully merging a pull request may close this issue.

3 participants