-
-
Notifications
You must be signed in to change notification settings - Fork 777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bug that prevents GHA "Schedule Thursday 1100" from running #4768
Comments
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Text for message$assignee Our team bot has determined that you have not been active in the last 30 days. You have been unassigned from all other issues and we are going to go ahead and close this issue and remove you from the write team. If this is a mistake or you would like return to the Hack for LA website team
Our bot made a mistake, let us know
I want to come back to the team
If its been less than 20 days
If its been more than 20 days
|
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Hi @t-will-gillis, thank you for taking up this issue! Hfla appreciates you :) Do let fellow developers know about your:- You're awesome! P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :) |
Prerequisite
Overview
We need our GitHub actions to run on the schedule we set so that we can continue to maintain our workflow. For over a year the GHA "Schedule Thursday 1100" has failed before completion, and the source(s) of the error need to be addressed.
Details
When reviewing HfLA "Actions" logs on the repo, it can be seen that the GHA "Schedule Thursday 1100" was been running weekly for almost a year. For the first Thursday of the month, the GHA fails. For the remaining Thursday, the GHA runs successfully because it is setting up the
trim-contributors
job, however that job is only scheduled to run on the first Thursday. In other words, these runs are unnecessary.Also, the paths on current Lines 38 and 45 are incorrect and need to be refactored.
Action Items
trim-contributors
job is only being initiated on the first day of the month, and not every Thursday as it is currently.On the yml file, change versions: line 24 toactions/checkout@v3
per PR 4735 and line 30 toactions/setup-node@v3
per PR 4739working-directory
in the step "Install npm dependencies" needs to be refactored to the correct directory- i.e./github-data/
. (ref PR 3359).run
path as shown in the step "Trim Members" needs to be refactored to the correct path tocontributors-data.js
.package.json
file and currently can't be found. To address this, either:@octokit/rest
andtrue-github-contributors
or if this isn't possiblecontributors.js
to the/github-data/
folder- and a.) remove the now empty/trim-contributors/
folder and b.) adjust the path in the .yml accordingly.on: workflow_dispatch
.Merge Team/ Leads:
When this issue is merged, can immediately approve and merge Bump actions/setup-node from 2 to 3 #4739 (if testing fixes bug on the GHA with the new version number, this is evidence that changing the version number is acceptable)TheAnswer is yes, this job is moved totrim-contributors
job is the only one running inschedule-thu-1100.yml
, and it is running only once a month. Should the job move toschedule-monthly.yml
?schedule-monthly.yml
Resources/Instructions
Additional Resources
The text was updated successfully, but these errors were encountered: