Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesigned homepage's CoP section img tag: Add alt property and remove the / #3792

Closed
8 tasks done
JessicaLucindaCheng opened this issue Jan 4, 2023 · 5 comments
Closed
8 tasks done
Assignees
Labels
Complexity: Small Take this type of issues after the successful merge of your second good first issue Feature: Feature Branch Requires Branching off a Feature Branch instead of gh-pages P-Feature: Home page https://www.hackforla.org/ role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours Status: Updated No blockers and update is ready for review

Comments

@JessicaLucindaCheng
Copy link
Member

JessicaLucindaCheng commented Jan 4, 2023

Overview

On the redesigned homepage's Communities of Practice (CoP) section's images,

  • we want to add an alt property so that the images are Web Content Accessibility Guidelines (WCAG) compliant and
  • we want to remove the / at the end of the img tag so that img tags are used uniformly across our website

Details

Click here to see a screenshot of the redesigned homepage's Communities of Practice section

Action Items

  • Feature Branch: You will be working off a feature branch called feature-homepage-launch. Please follow "Step 1: Create your branch" in How to work off of a feature branch wiki article.
  • In VS Code or another IDE on your computer, navigate to _includes/home-page/home-communities.html and change the following from
    <img src="{{ community[1].icon }}" />
    
    to
    <img src="{{ community[1].icon }}" alt="">
    
  • Using developer tools in your browser, on the redesigned homepage,
    • Check the alt property shows up for each of the images under the Communities of Practice section. (Note: Sometimes when you have alt="" in the code, it will show up as alt when you view the image using developer tools. This is acceptable.)
    • Check your changes do not break anything on the website in mobile, tablet, and desktop views
  • To update your topic branch, please follow "Step 2: Update your branch with upstream changes" in How to work off of a feature branch wiki article.
  • The pull request created from this issue should be merged into feature-homepage-launch. Please follow "Step 3: Create a pull request" in How to work off of a feature branch wiki article

Tech Lead or Merge Team

  • After the pull request associated with this issue is approved and merged, please make sure this issue is closed. If it is not closed by the automation, leave a new comment stating what pr number fixes this issue and then close this issue as completed.

Resources/Instructions

@JessicaLucindaCheng JessicaLucindaCheng added role: front end Tasks for front end developers P-Feature: Home page https://www.hackforla.org/ Complexity: Small Take this type of issues after the successful merge of your second good first issue Feature: Feature Branch Requires Branching off a Feature Branch instead of gh-pages size: 0.25pt Can be done in 0.5 to 1.5 hours Draft Issue is still in the process of being created Ready for Prioritization and removed Draft Issue is still in the process of being created labels Jan 4, 2023
@vmaineng vmaineng self-assigned this Jan 23, 2023
@github-actions
Copy link

Hi @vmaineng, thank you for taking up this issue! Hfla appreciates you :)

Do let fellow developers know about your:-
i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?)
ii. ETA: (When do you expect this issue to be completed?)

You're awesome!

P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :)

@vmaineng
Copy link
Member

vmaineng commented Jan 24, 2023

i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?)
I am available to work on this issue right now.

ii. ETA: (When do you expect this issue to be completed?)
End of tomorrow after developer's meeting.

@vmaineng
Copy link
Member

Submitted a PR for this issue.

@vmaineng
Copy link
Member

Submitted a new PR to be merged with feature-homepage-launch instead of gh-pages

@github-actions github-actions bot added the Status: Updated No blockers and update is ready for review label Jan 27, 2023
@MattPereira
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Small Take this type of issues after the successful merge of your second good first issue Feature: Feature Branch Requires Branching off a Feature Branch instead of gh-pages P-Feature: Home page https://www.hackforla.org/ role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours Status: Updated No blockers and update is ready for review
Projects
Development

Successfully merging a pull request may close this issue.

4 participants