Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toolkit page: Make the Guides section cards' SVGs WCAG compliant #2929

Closed
15 of 19 tasks
JessicaLucindaCheng opened this issue Mar 5, 2022 · 8 comments · Fixed by #3726
Closed
15 of 19 tasks

Toolkit page: Make the Guides section cards' SVGs WCAG compliant #2929

JessicaLucindaCheng opened this issue Mar 5, 2022 · 8 comments · Fixed by #3726
Assignees
Labels
Complexity: Medium Feature: Accessibility Issues that would broaden website accessibility Feature: Refactor HTML P-Feature: Toolkit https://www.hackforla.org/toolkit/ role: front end Tasks for front end developers size: 2pt Can be done in 7-12 hours Status: Updated No blockers and update is ready for review

Comments

@JessicaLucindaCheng
Copy link
Member

JessicaLucindaCheng commented Mar 5, 2022

Overview

We need to edit the guide card SVGs on the Toolkit webpage so that we adhere to the Web Content Accessibility Guidelines (WCAG) and we can achieve our mission of inclusivity.

Action Items

For this issue, we will be adding the alt text property to the guide card images on the Toolkit webpage, which requires the HTML to be refactored.

  • Open _includes/guide-card.html in VS Code or your IDE, then change this line of code
    {% include {{ guide.svg }} %}
    
    to
    <img src={{ guide.svg | absolute_url }} alt="">
    
  • Move the 2FA.svg file from _includes\svg to the assets\images\guides\2FA directory
  • Move the survey-reporting-image.svg file from _includes\svg to the assets\images\guides\survey-reporting directory
  • Update the svg field for _guide-pages/2FA.html from
    svg: svg/2FA.svg
    
    to
    svg: /assets/images/guides/2FA/2FA.svg
    
  • Update the svg field for _guide-pages/survey-reporting-dashboard-guide.html from
    svg: svg/survey-reporting-image.svg
    
    to
    svg: /assets/images/guides/survey-reporting/survey-reporting-image.svg
    
  • Update the svg field from
    svg: svg/default.svg
    
    to
    svg: /assets/images/toolkit-default-card-image.png
    
    for the following files in the _guide-pages directory:
    • creating-kanban-project.html
    • figma-for-opensource-projects.html
    • github-issues.html
    • responsible-use-of-images-on-opensource-projects.html
    • setting-up-1password-on-opensource-project.html
    • showing-civictech-experience-on-linkedin.html
    • updates-team-pages-on-hflasite.html
    • using-kanban-project.html
  • Make sure the space between the image and text is there like how it is on the current live Toolkit webpage for mobile, tablet, and desktop views.

    Click here to see the spacing which I have indicated with an arrow when viewing the page in desktop view

    • If the spacing is not there, add the spacing back in; in VS Code or your IDE, edit the SCSS file _sass/components/_toolkit.scss and, if needed, edit the HTML in _includes/guide-card.html, such as the SCSS classes applied to the HTML
      • Make sure to reference the Figma design for the Toolkit page to determine the exact spacing for mobile and desktop views
  • Using Docker, make sure changes look good on mobile, tablet, and desktop views using developer tools and that nothing breaks

Resources/Instructions

@JessicaLucindaCheng JessicaLucindaCheng added role: front end Tasks for front end developers P-Feature: Toolkit https://www.hackforla.org/toolkit/ Feature: Accessibility Issues that would broaden website accessibility Complexity: Small Take this type of issues after the successful merge of your second good first issue size: 1pt Can be done in 4-6 hours labels Mar 5, 2022
@github-actions

This comment was marked as resolved.

@JessicaLucindaCheng

This comment was marked as resolved.

@JessicaLucindaCheng JessicaLucindaCheng added Draft Issue is still in the process of being created Complexity: Medium and removed Complexity: Small Take this type of issues after the successful merge of your second good first issue labels Jun 2, 2022
@JessicaLucindaCheng JessicaLucindaCheng changed the title DRAFT: Adding alt="" to guide card images on Toolkit page to follow WCAG Adding alt="" to guide card images on Toolkit page to follow WCAG Aug 8, 2022
@JessicaLucindaCheng JessicaLucindaCheng changed the title Adding alt="" to guide card images on Toolkit page to follow WCAG Toolkit page: Adding alt="" to guide card images Oct 13, 2022
@JessicaLucindaCheng JessicaLucindaCheng changed the title Toolkit page: Adding alt="" to guide card images Toolkit page: Make guide card SVGs comply with WCAG Oct 16, 2022
@JessicaLucindaCheng JessicaLucindaCheng changed the title Toolkit page: Make guide card SVGs comply with WCAG Toolkit page: Make guide card SVGs WCAG compliant Oct 16, 2022
@JessicaLucindaCheng

This comment was marked as resolved.

@JessicaLucindaCheng JessicaLucindaCheng added Ready for Prioritization and removed Draft Issue is still in the process of being created labels Oct 26, 2022
@bishrfaisal bishrfaisal added this to the x. Accessibility milestone Oct 30, 2022
@JessicaLucindaCheng JessicaLucindaCheng added the size: 2pt Can be done in 7-12 hours label Oct 30, 2022
@michaelmagen michaelmagen self-assigned this Nov 1, 2022
@github-actions
Copy link

github-actions bot commented Nov 1, 2022

Hi @michaelmagen, thank you for taking up this issue! Hfla appreciates you :)

Do let fellow developers know about your:-
i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?)
ii. ETA: (When do you expect this issue to be completed?)

You're awesome!

P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :)

@michaelmagen
Copy link
Member

Availability: 4 hours
ETA: 11/6/22

@github-actions github-actions bot added the Status: Updated No blockers and update is ready for review label Nov 4, 2022
@github-actions github-actions bot removed the Status: Updated No blockers and update is ready for review label Nov 11, 2022
@github-actions
Copy link

@michaelmagen

Please add update using the below template (even if you have a pull request). Afterwards, remove the 'To Update !' label and add the 'Status: Updated' label.

  1. Progress: "What is the current status of your project? What have you completed and what is left to do?"
  2. Blockers: "Difficulties or errors encountered."
  3. Availability: "How much time will you have this week to work on this issue?"
  4. ETA: "When do you expect this issue to be completed?"
  5. Pictures (optional): "Add any pictures of the visual changes made to the site so far."

If you need help, be sure to either: 1) place your issue in the developer meeting discussion column and ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel.

You are receiving this comment because your last comment was before Monday, November 7, 2022 at 11:21 PM PST.

@michaelmagen
Copy link
Member

  1. Working through tasks
  2. Time, working on finishing the task soon.
  3. 4 hours
  4. 11/15/22

@michaelmagen
Copy link
Member

Blocker: Having trouble with fixing the spacing between the image and text after applying the changes.

@github-actions github-actions bot added the Status: Updated No blockers and update is ready for review label Nov 18, 2022
@JessicaLucindaCheng JessicaLucindaCheng changed the title Toolkit page: Make guide card SVGs WCAG compliant Toolkit page, Guides section: Make guide card SVGs WCAG compliant Jan 29, 2023
@JessicaLucindaCheng JessicaLucindaCheng changed the title Toolkit page, Guides section: Make guide card SVGs WCAG compliant Toolkit page: Make the Guides section cards' SVGs WCAG compliant Jan 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Medium Feature: Accessibility Issues that would broaden website accessibility Feature: Refactor HTML P-Feature: Toolkit https://www.hackforla.org/toolkit/ role: front end Tasks for front end developers size: 2pt Can be done in 7-12 hours Status: Updated No blockers and update is ready for review
Projects
Development

Successfully merging a pull request may close this issue.

4 participants