-
-
Notifications
You must be signed in to change notification settings - Fork 786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Edit content field and remove type field from winner.yml credits file #2871
Comments
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Hi @ychang49265, thank you for taking up this issue! Hfla appreciates you :) Do let fellow developers know about your:- You're awesome! P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :) |
i. Availability: throughout the week/flexible |
Blockers:
|
This comment was marked as outdated.
This comment was marked as outdated.
@ychang49265 If you have not yet gotten help for the blocker above, please post a message in the Slack channel with a link to your comment. Happy New Year! |
Please add update using the below template (even if you have a pull request). Afterwards, remove the 'To Update !' label and add the 'Status: Updated' label.
If you need help, be sure to either: 1) place your issue in the developer meeting discussion column and ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel. You are receiving this comment because your last comment was before Monday, January 9, 2023 at 11:16 PM PST. |
Prerequisite
Overview
As a developer, I want to edit the content field and remove the type field from a credit's yml file so that redundant code is removed and the code is easier to understand.
Details
Currently, in each credit's yml file, there is a
content
field and atype
field, which contains similar information. Since the fields are redundant, we decided to remove thetype
field.Also, we changed the
content
field to thecontent-type
field to make it clearer what its purpose is. The possible values forcontent-type
field are image, video, or audio; other types of content can be added if necessary. In the future, this will allow developers a way to differentiate easily between different types of content in order to show each credit's media file correctly on the website.Action Items
For the file
_data/internal/credits/winner.yml
, do the following:Resources/Instructions
File and Code links you will need to work on this issue
Directory to find the page in once you have it in your IDE:
_data/internal/credits/winner.yml
Click on the links below to see the source file code:
website/_data/internal/credits/winner.yml
Line 4 in 7164ec2
website/_data/internal/credits/winner.yml
Line 11 in 7164ec2
The text was updated successfully, but these errors were encountered: