Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete refactor/standardization of all buttons within Wins Page #2187

Closed
5 tasks done
abuna1985 opened this issue Aug 27, 2021 · 6 comments · Fixed by #2918
Closed
5 tasks done

Complete refactor/standardization of all buttons within Wins Page #2187

abuna1985 opened this issue Aug 27, 2021 · 6 comments · Fixed by #2918
Assignees
Labels
Complexity: Small Take this type of issues after the successful merge of your second good first issue Feature: Design system Feature: Refactor CSS Page is working fine - CSS needs changes to become consistent with other pages Feature: Refactor HTML Fun Congrats! You finished two good first issues. Please only do one of these P-Feature: Wins Page https://www.hackforla.org/wins/ role: front end Tasks for front end developers size: missing

Comments

@abuna1985
Copy link
Member

abuna1985 commented Aug 27, 2021

Overview

We need to refactor for buttons within the Home page from the recommendations in the CSS standardization spreadsheet (resource below) so that we have a consistent button appearance through the HfLA site.

Note: The buttons should have the same length and width after the changes. if it is not, please add CSS styling to make sure they match.

Action Items

  • Make the 1 recommended edits for the buttons from the spreadsheet below (1 files will be updated)
    • Update line 5 of website/pages/wins/wins-hero.html with HTML from the Reccomendation column
  • Confirm after the recommended edits that the Action of each button works as intended within the Home page
  • Confirm the button length/width are the same after changes. If not add CSS (this can be accomplished with custom padding for the specific button element)
  • Create a Pull Request with the proposed changes to the button

Resources/Instructions

https://hackforla.org/wins/
Google Sheets - CSS Standardization Buttons
#1921

@abuna1985 abuna1985 added role: front end Tasks for front end developers Feature: Refactor CSS Page is working fine - CSS needs changes to become consistent with other pages P-Feature: Wins Page https://www.hackforla.org/wins/ Feature: Design system Complexity: Small Take this type of issues after the successful merge of your second good first issue Feature: Feature Branch Requires Branching off a Feature Branch instead of gh-pages labels Aug 27, 2021
@github-actions
Copy link

Hi @abuna1985.

Good job adding the required labels to this issue.

Just a friendly reminder to also move the issue into the "New Issue Approval" column under the Project Board. For more info on that, check Github's documentation here.
Thanks!

Additional Resources:
Wiki: How to add status labels to issues (WIP. Link will be updated when the wiki is done)
Wiki: How to create issues (WIP. Link will be updated when the wiki is done)

@abuna1985
Copy link
Member Author

abuna1985 commented Aug 27, 2021

@Zhu-Joseph I see you self-assigned this issue. It is still being reviewed and is in the New Issue Approval column. Feel free to check the Prioritized Backlog Column to see what issues are available.

@abuna1985 abuna1985 added the Fun Congrats! You finished two good first issues. Please only do one of these label Aug 27, 2021
@Zhu-Joseph
Copy link
Member

@Zhu-Joseph I see you self-assigned this issue. It is still being reviewed and is in the New Issue Approval column. Feel free to check the Prioritized Backlog Column to see what issues are available.

Hey Adam, got it! I will just check something else out!

@abuna1985 abuna1985 removed the Feature: Feature Branch Requires Branching off a Feature Branch instead of gh-pages label Aug 29, 2021
@ExperimentsInHonesty ExperimentsInHonesty added this to the y. Technical debt milestone Sep 5, 2021
@Sparky-code Sparky-code self-assigned this Feb 28, 2022
@Sparky-code
Copy link
Member

ETA: Wednesday 3/02/22 EOD
Avail: 1hr Tuesday 3/01, + Time needed on Wednesday while on call

@Sparky-code
Copy link
Member

ETA: Friday 3/04/22 EOD
Blocker: Access to google sheets is restricted, waiting for access confirmation
Avail: Wednesday 7-9p PST, and same times through friday

@Sparky-code Sparky-code added the Status: Help Wanted Internal assistance is required to make progress label Mar 2, 2022
@JessicaLucindaCheng
Copy link
Member

@Sparky-code You should have access to the Google Sheet now, so I'm removing the "Status: Help Wanted" label. If you need help with something else, please let me know.

@JessicaLucindaCheng JessicaLucindaCheng removed the Status: Help Wanted Internal assistance is required to make progress label Mar 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Small Take this type of issues after the successful merge of your second good first issue Feature: Design system Feature: Refactor CSS Page is working fine - CSS needs changes to become consistent with other pages Feature: Refactor HTML Fun Congrats! You finished two good first issues. Please only do one of these P-Feature: Wins Page https://www.hackforla.org/wins/ role: front end Tasks for front end developers size: missing
Projects
Development

Successfully merging a pull request may close this issue.

7 participants