Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wins page - make the tablet like the mobile view #1950

Closed
3 tasks done
jbubar opened this issue Jul 15, 2021 · 9 comments · Fixed by #1954
Closed
3 tasks done

Wins page - make the tablet like the mobile view #1950

jbubar opened this issue Jul 15, 2021 · 9 comments · Fixed by #1954
Assignees
Labels
Milestone

Comments

@jbubar
Copy link
Member

jbubar commented Jul 15, 2021

Overview

@daniellex0 indicated in the issue below that we should have the wins page look like the mobile view in tablet (below 960px)

Action Items

  • discover where in the css and html the screen size is being used to determine the layout of the wins page
  • Make it so the current mobile view layout is expanded to include tablet view
  • Check to see that the see more see less functionality still works

Resources/Instructions

IMPORTANT - This issue is working off of a feature branch!
Please follow this wiki before creating a new branch!
how to work off a feature branch

@jbubar
Copy link
Member Author

jbubar commented Jul 18, 2021

Thanks Erika!

@jbubar
Copy link
Member Author

jbubar commented Jul 18, 2021

progress: Did this
blockers: Found a few more bugs that I want to fix with the same pr
ETA: Tomorrow
availability: Today after 5pm

@Sihemgourou Sihemgourou added the Status: Updated No blockers and update is ready for review label Jul 18, 2021
@Aveline-art Aveline-art linked a pull request Jul 19, 2021 that will close this issue
@github-actions github-actions bot added Test: Update Label and removed Status: Updated No blockers and update is ready for review Test: Update Label labels Aug 4, 2021
@github-actions
Copy link

github-actions bot commented Aug 6, 2021

@jbubar

Please add update using this template (even if you have a pull request)

  1. Progress: "What is the current status of your project? What have you completed and what is left to do?"
  2. Blockers: "Difficulties or errors encountered."
  3. Availability: "How much time will you have this week to work on this issue?"
  4. ETA: "When do you expect this issue to be completed?"
  5. Pictures: "Add any pictures of the visual changes made to the site so far."

If you need help, be sure to either: 1) ask for help at a Tuesday or Sunday meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel.

You are receiving this comment because your last comment was before Tuesday, August 3, 2021 at 7:53 AM.


Note: This comment was created as part of a GitHub Action during its trial phase. If you find this GitHub Action to be disruptive/unhelpful, or if you believe there might be a bug, please leave a comment on this issue. All feedback will be used to further improve it. Thank you for your time.

@github-actions
Copy link

@jbubar

Please add update using this template (even if you have a pull request)

  1. Progress: "What is the current status of your project? What have you completed and what is left to do?"
  2. Blockers: "Difficulties or errors encountered."
  3. Availability: "How much time will you have this week to work on this issue?"
  4. ETA: "When do you expect this issue to be completed?"
  5. Pictures: "Add any pictures of the visual changes made to the site so far."

If you need help, be sure to either: 1) ask for help at a Tuesday or Sunday meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel.

You are receiving this comment because your last comment was before Tuesday, August 10, 2021 at 12:10 AM.


Note: This comment was created as part of a GitHub Action during its trial phase. If you find this GitHub Action to be disruptive/unhelpful, or if you believe there might be a bug, please leave a comment on this issue. All feedback will be used to further improve it. Thank you for your time.

@abuna1985
Copy link
Member

@jbubar Are you still working on this? I do not see an update for 2 weeks.

@macho-catt
Copy link
Member

Will contact @jbubar about the issue. If there's no contact, we will recycle the issue.

@jbubar
Copy link
Member Author

jbubar commented Aug 18, 2021

Pretty sure that this is done. Sorry for being mia

@ExperimentsInHonesty
Copy link
Member

@abuna1985 please UAT this

@abuna1985
Copy link
Member

abuna1985 commented Oct 23, 2021

@ExperimentsInHonesty No other issues were found.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging a pull request may close this issue.

6 participants