Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize photo page cards in mobile Events page #1920

Closed
2 tasks done
daniellex0 opened this issue Jul 11, 2021 · 8 comments · Fixed by #2149
Closed
2 tasks done

Standardize photo page cards in mobile Events page #1920

daniellex0 opened this issue Jul 11, 2021 · 8 comments · Fixed by #2149
Assignees
Labels
Complexity: Medium Feature: Refactor CSS Page is working fine - CSS needs changes to become consistent with other pages role: front end Tasks for front end developers size: missing To Update ! No update has been provided UAT: no visuals

Comments

@daniellex0
Copy link
Member

daniellex0 commented Jul 11, 2021

Overview

We need to try to standardize the image page cards' mobile view in the Events page, because the images are too tall

Action Items

  • Try to decrease the mobile view height of the images in the Events page's image cards, to match similar ones in other pages' mobile view (like Program Areas) - see screenshots below for reference
    • Try to make sure the location text still appears- try to cut off the top of the image instead

Resources/Instructions

Events page
Program Areas (reference for good page card mobile image height)

Current Events page mobile page card image height (too tall)
Screen Shot 2021-07-11 at 8 58 16 AM
What the height should look like:
Screen Shot 2021-07-11 at 8 58 25 AM
@daniellex0 daniellex0 added role: front end Tasks for front end developers Complexity: Medium Feature: Refactor CSS Page is working fine - CSS needs changes to become consistent with other pages labels Jul 11, 2021
@MariannaAskova MariannaAskova self-assigned this Jul 15, 2021
@Sihemgourou Sihemgourou added Status: Updated No blockers and update is ready for review To Update ! No update has been provided and removed Status: Updated No blockers and update is ready for review labels Jul 17, 2021
@github-actions
Copy link

@MariannaAskova Please add update

  1. Progress
  2. Blockers
  3. Availability
  4. ETA

@github-actions
Copy link

github-actions bot commented Jul 23, 2021

This was a test, please disregard this. -- @Aveline-art

@github-actions
Copy link

github-actions bot commented Aug 6, 2021

@MariannaAskova

Please add update using this template (even if you have a pull request)

  1. Progress: "What is the current status of your project? What have you completed and what is left to do?"
  2. Blockers: "Difficulties or errors encountered."
  3. Availability: "How much time will you have this week to work on this issue?"
  4. ETA: "When do you expect this issue to be completed?"
  5. Pictures: "Add any pictures of the visual changes made to the site so far."

If you need help, be sure to either: 1) ask for help at a Tuesday or Sunday meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel.

You are receiving this comment because your last comment was before Tuesday, August 3, 2021 at 7:53 AM.


Note: This comment was created as part of a GitHub Action during its trial phase. If you find this GitHub Action to be disruptive/unhelpful, or if you believe there might be a bug, please leave a comment on this issue. All feedback will be used to further improve it. Thank you for your time.

@github-actions
Copy link

@MariannaAskova

Please add update using this template (even if you have a pull request)

  1. Progress: "What is the current status of your project? What have you completed and what is left to do?"
  2. Blockers: "Difficulties or errors encountered."
  3. Availability: "How much time will you have this week to work on this issue?"
  4. ETA: "When do you expect this issue to be completed?"
  5. Pictures: "Add any pictures of the visual changes made to the site so far."

If you need help, be sure to either: 1) ask for help at a Tuesday or Sunday meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel.

You are receiving this comment because your last comment was before Tuesday, August 10, 2021 at 12:10 AM.


Note: This comment was created as part of a GitHub Action during its trial phase. If you find this GitHub Action to be disruptive/unhelpful, or if you believe there might be a bug, please leave a comment on this issue. All feedback will be used to further improve it. Thank you for your time.

@abuna1985
Copy link
Member

@MariannaAskova Are you still working on this issue? I do not see an update for 2 weeks now.

@macho-catt macho-catt removed the To Update ! No update has been provided label Aug 18, 2021
@macho-catt
Copy link
Member

We're putting this back to the backlog for the time being since the issue has not been worked on for two weeks.

@blakes24 blakes24 self-assigned this Aug 20, 2021
@github-actions
Copy link

@blakes24

Please add update using this template (even if you have a pull request)

  1. Progress: "What is the current status of your project? What have you completed and what is left to do?"
  2. Blockers: "Difficulties or errors encountered."
  3. Availability: "How much time will you have this week to work on this issue?"
  4. ETA: "When do you expect this issue to be completed?"
  5. Pictures: "Add any pictures of the visual changes made to the site so far."

If you need help, be sure to either: 1) ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel.

You are receiving this comment because your last comment was before Tuesday, August 17, 2021 at 12:02 AM PST.

@github-actions github-actions bot added the To Update ! No update has been provided label Aug 20, 2021
@blakes24
Copy link
Member

Update

  1. Progress: Pull request made
  2. Blockers: None
  3. Availability: open
  4. ETA: pending review
  5. Pictures:

Screen Shot 2021-08-20 at 11 49 09 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Medium Feature: Refactor CSS Page is working fine - CSS needs changes to become consistent with other pages role: front end Tasks for front end developers size: missing To Update ! No update has been provided UAT: no visuals
Projects
Development

Successfully merging a pull request may close this issue.

9 participants