-
-
Notifications
You must be signed in to change notification settings - Fork 778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove additional space from wins-card-mobile.svg within WIns About page (mobile only) #1908
Comments
@anonymousanemone this was so entertaining to read! you might be the next xkcd. Ok this is super janky but... going off your negative padding idea... .wins-card-mobile img{
margin-left: -20px;
width: calc(100% + 10px);
} But I think it is mostly because you just need a new img.. that img has a lot of extra space around the card. maybe get an svg of the wins card without the box shadow and add the box shadow on using css? Its up to you.. but thanks for giving us an opportunity to give our 2 cents |
Fully agree with @jbubar. That image was great. Jumping off of the new image idea, I have looked into the history of that page . (Fun fact: I had to recreate the original folder in my own version of the directory to see the history since the original about-us folder was renamed to about). It seems that the original image was there since creation, and the creator of the page had a preference for SVGs. If you decide to recreate the image here is a list of tools for creating SVGs. Or you can lift the Figma design and use a png file. In any case, good job for sticking at this for so long. Edit: Went on a bit of a rabbit-hole, and found this StackOverFlow that might help? |
@anonymousanemone Please add update
|
Progress: Submitted pull request, but received request for changes |
Please add update using this template (even if you have a pull request)
If you need help, be sure to either: 1) ask for help at a Tuesday or Sunday meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel. You are receiving this comment because your last comment was before Tuesday, August 3, 2021 at 7:53 AM. Note: This comment was created as part of a GitHub Action during its trial phase. If you find this GitHub Action to be disruptive/unhelpful, or if you believe there might be a bug, please leave a comment on this issue. All feedback will be used to further improve it. Thank you for your time. |
Progress: Made hopefully last commit |
Overview
Remove the additional 31px of additional space from the
/assets/images/about/wins-card-mobile.svg
. We are currently using this<svg>
withinpages/about/about-card-accomplishments.html
.Current About Page (mobile view)
About Page (mobile view) figma design
Current wins-card-mobile.svg
Action Items
<svg>
./assets/images/about/wins-card-mobile.svg
to remove the 31px of additonal spaceResources/Instructions
viewBox
attributeThe text was updated successfully, but these errors were encountered: