Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement the redesign on the final summary page #421

Closed
3 tasks
KPHowley opened this issue Jun 11, 2020 · 6 comments · Fixed by #435 or #461
Closed
3 tasks

Implement the redesign on the final summary page #421

KPHowley opened this issue Jun 11, 2020 · 6 comments · Fixed by #435 or #461
Assignees
Labels
enhancement Release Note: Shows as visual or user experience Enhancement level: missing priority: missing role: front-end Front End Developer

Comments

@KPHowley
Copy link
Member

KPHowley commented Jun 11, 2020

Overview

Implement the new redesign of the final summary page as shown in the attached mock up.

Action Items

  • Redesign page according to design.
  • When "Save project" button is pressed than make it so the user is not redirected from the page
  • When "Save project" button is pressed add a time stamp next to it that noted the last modified date

Resources/Instructions

Design

VER 2  tdm-summary

Resource

@KPHowley KPHowley added the role: front-end Front End Developer label Jun 11, 2020
@alexchoiweb alexchoiweb self-assigned this Jun 12, 2020
@KPHowley KPHowley added this to the 6/22/2020 milestone Jun 23, 2020
@nclairesays nclairesays reopened this Jun 23, 2020
@nclairesays
Copy link
Member

I went ahead and approved the pull request so that we can have this as part of our meeting with LADOT tomorrow. However, I noticed that the time stamp is not in the same location as the figma design above. Are we ok with this? @KPHowley @dazainus @alexchoiweb
image

@KPHowley
Copy link
Member Author

I believe we discussed the last save location staying up there in case the title is long, and Diane actually changed that in the figma design, however we didn't update the screenshot!

The only thing I noticed was that the button says "Save as new project" if the project hasn't been saved before and "Save project" if it has. I don't think this is necessary and just puts too much text in there, but will defer to @dazainus.

@KPHowley
Copy link
Member Author

KPHowley commented Jun 24, 2020

@alexchoiweb , @nclairesays - I actually have some updates on this that we want to change before pushing to live - most of these were on the design too (I should've reviewed it more thoroughly!)...

We want to make these changes:

  • The encouragement program is being shown as selected, even though it was not selected and 0 points were awarded (seems to happen for all projects)
  • The earned points does not actually apply for the "required parking calculation" and so we want to remove that column and right justify the other data.
  • We want to rename "required parking calculation" to "Project Specifications" to be consistent
  • We want to change the label on the figures at the bottom from pts to spcs

Screen Shot 2020-06-24 at 4 18 42 PM

This screenshot from "Different Version of Clarendon Apartments" saved in the [email protected] account if you want to check it!

@alexchoiweb
Copy link
Member

3/4 of requested changes implemented

For the encouragement program issue - with some testing I see that toggling the dropdown for Encouragement Program in the wizard to a value that is not 'none' and then back to 'none' resolves the issue of the encouragement program rule being displayed in the final summary. I just can't save this change in the project with the account that I have.

Also I tested creating a new project and not using the encouragement program rule and found that the rule doesn't show in the final summary page, functioning as expected.

Let me know if there are more issues you find however

@nclairesays
Copy link
Member

@alexchoiweb sending you info on slack with the login credentials for [email protected] account

@alexchoiweb
Copy link
Member

alexchoiweb commented Jun 30, 2020

Issue fixed for Clarendon Apartments using [email protected] account but for every other issue the user will have to go through the process above and save which will resolve the issue.

Going forward new issues will not be generated when creating new projects and leaving the encouragment program dropdown to none

Screen Shot 2020-06-30 at 10 43 14 AM

If we want to fix all the current issues on our side, here's an image of what's probably going wrong - encouragement program dropdown is set to 'none' in the wizard but when the rule data comes back, the properties of used:true, value:true is still returned for the encouragement program rule. For other non-used rules, the property of used is usually true but the value is usually null (and therefore hidden)

Screen Shot 2020-06-29 at 4 00 32 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Release Note: Shows as visual or user experience Enhancement level: missing priority: missing role: front-end Front End Developer
Projects
Archived in project
5 participants