-
-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement the redesign on the final summary page #421
Comments
I went ahead and approved the pull request so that we can have this as part of our meeting with LADOT tomorrow. However, I noticed that the time stamp is not in the same location as the figma design above. Are we ok with this? @KPHowley @dazainus @alexchoiweb |
I believe we discussed the last save location staying up there in case the title is long, and Diane actually changed that in the figma design, however we didn't update the screenshot! The only thing I noticed was that the button says "Save as new project" if the project hasn't been saved before and "Save project" if it has. I don't think this is necessary and just puts too much text in there, but will defer to @dazainus. |
@alexchoiweb , @nclairesays - I actually have some updates on this that we want to change before pushing to live - most of these were on the design too (I should've reviewed it more thoroughly!)... We want to make these changes:
This screenshot from "Different Version of Clarendon Apartments" saved in the [email protected] account if you want to check it! |
3/4 of requested changes implemented For the encouragement program issue - with some testing I see that toggling the dropdown for Encouragement Program in the wizard to a value that is not 'none' and then back to 'none' resolves the issue of the encouragement program rule being displayed in the final summary. I just can't save this change in the project with the account that I have. Also I tested creating a new project and not using the encouragement program rule and found that the rule doesn't show in the final summary page, functioning as expected. Let me know if there are more issues you find however |
@alexchoiweb sending you info on slack with the login credentials for [email protected] account |
Issue fixed for Clarendon Apartments using [email protected] account but for every other issue the user will have to go through the process above and save which will resolve the issue. Going forward new issues will not be generated when creating new projects and leaving the encouragment program dropdown to none If we want to fix all the current issues on our side, here's an image of what's probably going wrong - encouragement program dropdown is set to 'none' in the wizard but when the rule data comes back, the properties of |
Overview
Implement the new redesign of the final summary page as shown in the attached mock up.
Action Items
Resources/Instructions
Design
Resource
The text was updated successfully, but these errors were encountered: