Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix all current code style and lint errors #262

Closed
fyliu opened this issue Feb 26, 2020 · 2 comments · Fixed by #263 or #265
Closed

Fix all current code style and lint errors #262

fyliu opened this issue Feb 26, 2020 · 2 comments · Fixed by #263 or #265
Assignees
Labels
bug Release Note: Shows as Error Correction level: hard priority: missing role: missing

Comments

@fyliu
Copy link
Member

fyliu commented Feb 26, 2020

Overview

Run all the code through prettier and eslint and fix any lint or runtime proptype errors.

@fyliu fyliu added bug Release Note: Shows as Error Correction level: hard labels Feb 26, 2020
@fyliu fyliu self-assigned this Feb 26, 2020
@fyliu fyliu linked a pull request Feb 26, 2020 that will close this issue
@fyliu
Copy link
Member Author

fyliu commented Feb 26, 2020

I executed this command from the client directory to add a space to all the js files so I could stage them for prettier and eslint to check:
find .. -type d ( -path ../client/node_modules -o -path ../node_modules ) -prune -o -type f -name "*.js" -exec sh -c " echo ' ' >> {}" ;

@fyliu
Copy link
Member Author

fyliu commented Feb 26, 2020

These are the only files that need to be checked later. They contain other problems better addressed in separate issues.
app/controllers/account.controller.js
client/src/components/TdmCalculationContainer.js
client/src/services/account-service.js

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Release Note: Shows as Error Correction level: hard priority: missing role: missing
Projects
Archived in project
2 participants