Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: Wizard to use react-router to render steps #232

Closed
bfojas opened this issue Feb 12, 2020 · 3 comments
Closed

Refactor: Wizard to use react-router to render steps #232

bfojas opened this issue Feb 12, 2020 · 3 comments
Assignees
@bfojas
Labels
enhancement Release Note: Shows as visual or user experience Enhancement level: missing priority: missing refactor Release Note: Shows as System Update role: front-end Front End Developer

Comments

@bfojas
Copy link
Member

bfojas commented Feb 12, 2020

Overview

Refactor the wizard to use react router rather than a large ternary.

Action Items

  • Create components for each step in the wizard.
  • Refactor wizard logic to step based on route
@bfojas bfojas self-assigned this Feb 12, 2020
@bfojas bfojas added role: front-end Front End Developer enhancement Release Note: Shows as visual or user experience Enhancement labels Feb 12, 2020
@ExperimentsInHonesty
Copy link
Member

@bfojas @mmorgs is this a dependency for Issue #209. If yes, please post something on that issue about it (and here too) , and move the issue to the icebox. When this issue is complete, that other issue can be moved back into prioritized backlog.

Closed
1 task
@bfojas bfojas mentioned this issue Feb 19, 2020
Merged
@ExperimentsInHonesty
Copy link
Member

@bfojas decided not to use React router. Instead we changed each of the steps into their own component using a switch statement instead of the ternary.

@bfojas
Copy link
Member Author

bfojas commented Feb 22, 2020

Closed with PR #249

@fyliu fyliu added the refactor Release Note: Shows as System Update label Mar 28, 2020
@ExperimentsInHonesty ExperimentsInHonesty changed the title Refactor Wizard to use react-router to render steps Refactor: Wizard to use react-router to render steps Sep 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bfojas bfojas

Labels
enhancement Release Note: Shows as visual or user experience Enhancement level: missing priority: missing refactor Release Note: Shows as System Update role: front-end Front End Developer
Projects
P: TDM: project board
Archived in project
Milestone
No milestone
Development

No branches or pull requests
4 participants
@fyliu @ExperimentsInHonesty @bfojas @luca-navarrete