Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor changes to Filtering UI Mockup to match the style guide #1838

Closed
6 of 7 tasks
Tracked by #1816
NilakshiS opened this issue Sep 10, 2024 · 6 comments
Closed
6 of 7 tasks
Tracked by #1816

Minor changes to Filtering UI Mockup to match the style guide #1838

NilakshiS opened this issue Sep 10, 2024 · 6 comments

Comments

@NilakshiS
Copy link
Member

NilakshiS commented Sep 10, 2024

Overview

The Figma designs and prototypes created for the Filter functionality on My Projects page need to be updated to be consistent with the styles in the style guide.

Details

The style guide has some different styles than what the design mockups for filter use, we need to update the design mockups to keep it consistent with the style guide. There are also some suggestions to implement.

  1. Change "Show Result" on buttons to "Apply".
Details

The Primary Call to Action button on each popup is labelled "Show Result", but the usual word used for something like this is "Apply".

  • This is just John's opinion, so we can use another working if you want.
  • Product agrees Apply is more consistent with industry standard.
  • If Design has a different word we should use, please provide industry examples.
  • Examples
    • Google Sheets uses "OK"
  • Dev has already implemented this, see screenshot from dev site

  1. Apply the "Primary" button style from the style guide to the "Apply" button.
  2. Design a style for "Cancel" button or propose another from the existing styles.

    The Reset button is functionally equivalent to a Cancel button on, say the Duplicate Project Dialog, so we will apply that style unless directed otherwise. It's not clear to me if the style guide includes a button style for "Cancel". In some case Cancel is the Primary (safest option) and in others it might be Secondary, but maybe Cancel-type operations need their own button design.

Action Items

  • Implement the changes to the design mockup and update the designs and prototype on Figma:
    • Change "Show Result" on buttons to "Apply"
    • Apply the "Primary" button style from the style guide to the "Apply" button.
    • Design a style for "Cancel" button or propose another from the existing styles
  • Review with Product, Dev and Research and iterate if needed based on feedback.
  • Update the style guide to add the new design.
  • Once finalized, get Stakeholder sign-off via the stakeholder meeting slide deck.

Resources

@NilakshiS NilakshiS added this to the 10 - Launch milestone Sep 10, 2024
@github-project-automation github-project-automation bot moved this to New Issue Approval in P: TDM: project board Sep 10, 2024
@namigoeku namigoeku self-assigned this Sep 19, 2024
@NilakshiS NilakshiS moved this from Prioritized Backlog to In progress (actively working) in P: TDM: project board Sep 19, 2024
@NilakshiS NilakshiS moved this from In progress (actively working) to Prioritized Backlog in P: TDM: project board Sep 23, 2024
@serena1214 serena1214 self-assigned this Oct 5, 2024
@serena1214
Copy link
Member

serena1214 commented Oct 9, 2024

Redesign Cancel Button

  1. Progress: I made 3 new designs for the cancel button. I'd like to get the team's feedback before moving on to the next step.
  2. Blockers(Difficulties or errors encountered): Unsure about the best approach for updating designs and prototype in Figma. Should I update all pages individually?
  3. Availability: I will be busy next week, but I'll do my best to squeeze in about 3 hours for our project.
  4. ETA: Within 2 weeks.

https://www.figma.com/design/nD9QK56Mzq7xNSaSUoeGx0/TDM-Calculator?node-id=3337-11979&t=touGMwZ0jX3D4rMy-1

@ExperimentsInHonesty ExperimentsInHonesty removed the pbv: design all issues for design roles label Oct 10, 2024
@serena1214
Copy link
Member

Updated all the cancel and apply buttons on #1885 New prototype for filters and my projects based on dev site.

@NilakshiS
Copy link
Member Author

@serena1214 Could you also change the button text to "RESET" instead of "CANCEL". It is more accurate for use in context of filters and is also used on the dev site. I've added a "Button Text" property to the component so it should be easier to change the value for multiple instances.
image
)

@NilakshiS NilakshiS moved this from Visual Review to In progress (actively working) in P: TDM: project board Oct 14, 2024
@serena1214
Copy link
Member

Thank you @NilakshiS! I've updated all to "RESET"

@NilakshiS
Copy link
Member Author

New button styles suggested for cancel and reset buttons:

@NilakshiS NilakshiS moved this from Visual Review to Questions/Clarifications in P: TDM: project board Oct 24, 2024
@NilakshiS
Copy link
Member Author

New button styles have been approved by the stakeholders on 10/29/2024. Updated the new filter prototype (#1885) with the new design.
image

@github-project-automation github-project-automation bot moved this from Questions/Clarifications to On Dev - not yet pushed to Prod in P: TDM: project board Nov 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Released
Development

No branches or pull requests

4 participants