Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace all icons in the project with Material UI icons linked below in the resources section. #1790

Closed
3 tasks
Tracked by #1760
entrotech opened this issue Aug 16, 2024 · 0 comments · Fixed by #1810
Closed
3 tasks
Tracked by #1760
Assignees
Labels
enhancement Release Note: Shows as visual or user experience Enhancement feature: UI Cleanup & Documentation level: easy p-feature: My Projects Page /projects pbv: dev All engineering issues priority: MUST HAVE role: front-end Front End Developer role: ui/ux design size: 0.5pt Can be done in 2-3 hours or less
Milestone

Comments

@entrotech
Copy link
Member

entrotech commented Aug 16, 2024

Overview

Issue #1761 changed out (almost) all the fontawesome icons for icons from the Material Design library, but there are at least a few that are not in the style guide or inconsistent with the style guide. We need to resolve these discrepancies.

Actions

  • Review the current site for consistency of icons with the style guide. See the Reference section below for a few quick examples of discrepancies. Reach agreement with designers on required changes.
  • (Developer) Swap out the icons that need updated in the application.
  • (Designer) Make corresponding changes to the style guide.

Reference

Links to icons in Material UI

Examples of inconsistency:
The icon for the "Convert to Snapshot Modal Dialog" should be consistent with the corresponding kebab menu icon for the "Convert to Snapshot" menu item.

image

The style guide does not specify a new icon for the kebab menu item for Convert to Snapshot looked like a camera previously, and now looks like a camera aperture (and should be the same as on the previously mentioned dialog). It's up to the designers which one we want - it just needs to be consistent and documented in the style guide.

image

The Download to CSV icon on the multi-select toolbar and the kebab menu don't look quite like the style guide. Since there is no similar icon in Material Design, this is still a fontawesome design, and the discrepancy between the site and the style guide seems to be a difference in Fonawesome version 5 vs. fontawesome version 6.

@github-project-automation github-project-automation bot moved this to New Issue Approval in P: TDM: project board Aug 16, 2024
@entrotech entrotech added enhancement Release Note: Shows as visual or user experience Enhancement role: front-end Front End Developer level: easy feature: UI Cleanup & Documentation priority: MUST HAVE role: ui/ux design p-feature: My Projects Page /projects size: 0.5pt Can be done in 2-3 hours or less pbv: dev All engineering issues pbv: design all issues for design roles labels Aug 16, 2024
@entrotech entrotech moved this from New Issue Approval to Prioritized Backlog in P: TDM: project board Aug 16, 2024
@entrotech entrotech removed role: ui/ux design pbv: design all issues for design roles labels Aug 16, 2024
@entrotech entrotech added the pbv: design all issues for design roles label Aug 29, 2024
@Parisajf Parisajf added this to the 10 - Launch milestone Aug 29, 2024
@github-project-automation github-project-automation bot moved this from In progress (actively working) to On Dev - not yet pushed to Prod in P: TDM: project board Sep 4, 2024
@ExperimentsInHonesty ExperimentsInHonesty removed the pbv: design all issues for design roles label Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Release Note: Shows as visual or user experience Enhancement feature: UI Cleanup & Documentation level: easy p-feature: My Projects Page /projects pbv: dev All engineering issues priority: MUST HAVE role: front-end Front End Developer role: ui/ux design size: 0.5pt Can be done in 2-3 hours or less
Projects
Status: Released
Development

Successfully merging a pull request may close this issue.

4 participants