Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Web API endpoints to support Submitting a Project for Approval #1704

Closed
2 tasks done
entrotech opened this issue May 16, 2024 · 4 comments · Fixed by #1753
Closed
2 tasks done

Create Web API endpoints to support Submitting a Project for Approval #1704

entrotech opened this issue May 16, 2024 · 4 comments · Fixed by #1753
Assignees
Labels
enhancement Release Note: Shows as visual or user experience Enhancement level: medium p-feature: Submit Snapshot pbv: dev All engineering issues priority: MUST HAVE role: back-end Node/Express Development Task role: database Database Development Task size: 2pt Can be done in 7-12 hours
Milestone

Comments

@entrotech
Copy link
Member

entrotech commented May 16, 2024

Overview

In order to support features related to submitting a project for approval, we need to implement the web api endpoints and supporting database changes.

Action Items

  • Add a dateSubmitted column to the Project table.
  • Add a web api endpoint for HTTP PUT requests with url /api/proects/submit. The body will consist of the project id, and the route will use the jwtSession.validateUser middleware to verify the user identity. The Controller function should verify that the project id corresponds to the loginId of the user that owns the corresponding project, and call a service that, in turn, calls a Project_Submit stored procedure. The stored procedure should have argument projectId, loginId, and update the dateSubmitted column value to the current datetime. Most of this is very similar to the existing /api/projects/snapshot endpoint.

Resources/Instructions

@entrotech entrotech added enhancement Release Note: Shows as visual or user experience Enhancement level: medium p-feature: Submit Snapshot role: back-end Node/Express Development Task role: database Database Development Task size: 1pt Can be done in 4-6 hours labels May 16, 2024
@entrotech entrotech added this to the 10 - Launch milestone May 16, 2024
@ExperimentsInHonesty ExperimentsInHonesty moved this to In progress (actively working) in P: TDM: project board Jun 11, 2024
@ExperimentsInHonesty ExperimentsInHonesty added the pbv: dev All engineering issues label Jun 11, 2024
@Parisajf Parisajf added size: 2pt Can be done in 7-12 hours and removed size: 1pt Can be done in 4-6 hours labels Jun 13, 2024
@Parisajf
Copy link
Member

@heejung-hong
Please provide update

  1. Progress: "What is the current status of your project? What have you completed and what is left to do?"
  2. Blockers: "Difficulties or errors encountered."
  3. Availability: "How much time will you have this week to work on this issue?"
  4. ETA: "When do you expect this issue to be completed?"
  5. Pictures or links* (if necessary): "Add any pictures or links that will help illustrate what you are working on."
  • remember to add links to the top of the issue if they are going to be needed again.

@heejung-hong
Copy link
Member

@Parisajf

  1. Progress: Coded the backend, but could not complete route testing in Postman. Will work on creating the frontend submit button with modal and submit to John for review.
  2. Blockers: Wasn't able to complete test in Postman.
  3. Availability: Evenings
  4. ETA: Front-end by 6/19

@ExperimentsInHonesty
Copy link
Member

@heejung-hong
Please provide update

  1. Progress: "What is the current status of your project? What have you completed and what is left to do?"
  2. Blockers: "Difficulties or errors encountered."
  3. Availability: "How much time will you have this week to work on this issue?"
  4. ETA: "When do you expect this issue to be completed?"
  5. Pictures or links* (if necessary): "Add any pictures or links that will help illustrate what you are working on."
  • remember to add links to the top of the issue if they are going to be needed again.

@heejung-hong
Copy link
Member

Please find my update below.

  1. Progress: Need to create new migration script for Project_Submit store procedure and continue to work on a new endpoint.
  2. Blockers: Need to review the project.
  3. Availability: Weekdays after 6pm.
  4. ETA: Can't confirm the ETA at this time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Release Note: Shows as visual or user experience Enhancement level: medium p-feature: Submit Snapshot pbv: dev All engineering issues priority: MUST HAVE role: back-end Node/Express Development Task role: database Database Development Task size: 2pt Can be done in 7-12 hours
Projects
Status: Released
Development

Successfully merging a pull request may close this issue.

4 participants