Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-Implement the modal that warns user about navigating away from a page with unsaved changes. #1529

Closed
2 tasks
entrotech opened this issue Nov 21, 2023 · 0 comments · Fixed by #1538
Closed
2 tasks

Re-Implement the modal that warns user about navigating away from a page with unsaved changes. #1529

entrotech opened this issue Nov 21, 2023 · 0 comments · Fixed by #1538
Labels
bug Release Note: Shows as Error Correction level: medium p-feature: Project Page p1 Users Define Project including AIN, Adress, Ect. /calculation/1 priority: MUST HAVE role: front-end Front End Developer size: 0.5pt Can be done in 2-3 hours or less

Comments

@entrotech
Copy link
Member

Overview

To keep users from losing their work on the calculation wizard, we want to display the Navigation Confirm Dialog box if they attempt to leave the wizard without saving their changes. This was previously working before we upgraded to React Router, version 6, but used features that the router no longer supports.

Action Items

  • Read this post about the problem, and how to solve it.
  • Re-implement this feature.

Resources/Instructions

Dialog as it appeared before upgrading to react-router v6:

image
@entrotech entrotech added bug Release Note: Shows as Error Correction role: front-end Front End Developer level: medium priority: MUST HAVE p-feature: Project Page p1 Users Define Project including AIN, Adress, Ect. /calculation/1 size: 0.5pt Can be done in 2-3 hours or less labels Nov 21, 2023
@Jonathanko52 Jonathanko52 self-assigned this Nov 22, 2023
@entrotech entrotech mentioned this issue Nov 27, 2023
Merged
@ExperimentsInHonesty ExperimentsInHonesty moved this to On Dev - not yet pushed to Prod in P: TDM: project board Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Release Note: Shows as Error Correction level: medium p-feature: Project Page p1 Users Define Project including AIN, Adress, Ect. /calculation/1 priority: MUST HAVE role: front-end Front End Developer size: 0.5pt Can be done in 2-3 hours or less
Projects
P: TDM: project board
Status: Released
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

1529 reimplement NavConfirmModal hackforla/tdm-calculator
2 participants
@entrotech @Jonathanko52