Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update HTML components to MUI: ./src/components/manageProjects/eventForm.js #1699

Closed
6 tasks
Tracked by #1617
JackHaeg opened this issue Jul 16, 2024 · 12 comments · Fixed by #1844
Closed
6 tasks
Tracked by #1617

Update HTML components to MUI: ./src/components/manageProjects/eventForm.js #1699

JackHaeg opened this issue Jul 16, 2024 · 12 comments · Fixed by #1844
Assignees
Labels

Comments

@JackHaeg
Copy link
Member

JackHaeg commented Jul 16, 2024

Overview

Review all components in./src/components/manageProjects/eventForm.js and replace all standard HTML components with applicable MUI components.

Action Items

  • Review components in:./src/components/manageProjects/eventForm.js and search for any standard HTML components.
    • IF all components are already updated to relevant MUI
      • Comment on this issue that all components are already updated to MUI.
      • Close the issue & check the box associated with this issue on the MUI issue epic
      • Move on to the next MUI issue
    • IF standard HTML components are found in the file:
      • Replace these standard HTML components with applicable MUI components.
      • Make a PR for this file

Resources

@github-project-automation github-project-automation bot moved this to New Issue Approval in P: VRMS: Project Board Jul 16, 2024
@JackHaeg JackHaeg changed the title ./src/components/manageProjects/eventForm.js Update HTML components to MUI: ./src/components/manageProjects/eventForm.js Jul 16, 2024
@JackHaeg JackHaeg moved this from New Issue Approval to Prioritized Backlog in P: VRMS: Project Board Jul 16, 2024
@JackHaeg JackHaeg added this to the Y - Excellent Level milestone Jul 16, 2024
@sasszz sasszz self-assigned this Jan 21, 2025
@sasszz sasszz moved this from Prioritized Backlog to In progress in P: VRMS: Project Board Jan 21, 2025
@sasszz
Copy link
Member

sasszz commented Jan 21, 2025

Event form is located in a few places including Adding/Editing events in a Project. Example screenshot below:

Image

Components to be converted should be Modal, Input, Select and Button

@sasszz
Copy link
Member

sasszz commented Jan 21, 2025

@JackHaeg @trillium Hi, question, the MUI linked is for "Base UI" which is now deprecated. A different PR used Material UI ( mui #1813 that fixes #1694), which package for MUI should I use?

Image

@sasszz
Copy link
Member

sasszz commented Jan 21, 2025

Image

@trillium
Copy link
Member

Hey, please use the non-depricated package. If we need to install he correct MUI dependencies, please update package.json and yarn.lock in their own commit.

@sasszz
Copy link
Member

sasszz commented Jan 22, 2025

Hey thanks for the reply!

@trillium should we plan to use:

  • Material MUI
    • used in the last pr that was merged
  • Base UI
    • Most similar to the deprecated package of MUI Base which is the one linked in the ticket and other related issues
    • introduces an additional component package to the repo that may be redundant

@trillium
Copy link
Member

trillium commented Jan 22, 2025

Hey @sasszz, happy to clarify :)

Use Material MUI, the Base UI was a mistakely added resource

@JackHaeg
Copy link
Member Author

Hi @sasszz! When you have a moment, can you please provide an update with the following information:

  1. Progress: "What is the current status of your project? What have you completed and what is left to do?"
  2. Blockers: "Difficulties or errors encountered."
  3. Availability: "How much time will you have this week to work on this issue?"
  4. ETA: "When do you expect this issue to be completed?"
  5. Pictures or links* (if necessary): "Add any pictures or links that will help illustrate what you are working on."
  • remember to add links to the top of the issue if they are going to be needed again.

@sasszz
Copy link
Member

sasszz commented Jan 28, 2025

Hey Jack!

Draft PR open here: #1844

  1. Progress - 50% - scoped out issue, understand component, about 1/2 through refactoring. Although it's one form, it has multiple components (Modal, Input, Select and Button), making it a larger ticket (more like 0.5)
  2. Difficulties - I have 3:
    • Global CSS applied to all inputs make transition to MUI components tricky as the refactored MUI component has extra CSS acting upon it, resulting in weird dimensions/padding.
    • Should we consider extracting for example, the <Input> component to something reusable in other forms so we don't have to recreate it?
    • How close should I follow the styles of the prev component (pre-refactor)
  3. Availability - 10 hours this week
  4. If I could get advice on these blockers, I could get a final PR up EOW

@sasszz
Copy link
Member

sasszz commented Jan 28, 2025

@trillium just to confirm, adhering to current styles is not necessary? Maybe aim for close to the original component styles, but not exact?

@trillium
Copy link
Member

Correct, for this component feel free to use your judgement on what needs to change

@sasszz
Copy link
Member

sasszz commented Feb 4, 2025

Update!

Progress: PR is completed and ready for review #1844 
Blockers: Awaiting other dev approvals
Availability: Ready for new task
ETA: This week, after review process is completed

@sasszz
Copy link
Member

sasszz commented Feb 11, 2025

Update!

Progress: PR has one approval and is awaiting 1 more
Blockers: Awaiting other dev approval
Availability: Ready for new task
ETA: Today after today's meeting

@github-project-automation github-project-automation bot moved this from In progress to Final QA (product) in P: VRMS: Project Board Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Final QA (product)
Development

Successfully merging a pull request may close this issue.

3 participants