Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update db call to to receive email strings back from the db in lower case form #1480

Open
Tracked by #1456
trillium opened this issue Aug 26, 2023 · 3 comments
Open
Tracked by #1456

Comments

@trillium
Copy link
Member

trillium commented Aug 26, 2023

Dependency

Complete after #1551

Overview

This is part of #1456

We need to receive email addresses as lowercase from the db so that duplicates of different casing ([email protected], [email protected]) aren't able to be created.

Action Items

Either:

  • Update the db so that all emails are already lowercase
    (this is the preferred solution, but we will need to handle duplicate addresses which increases complexity)

Or:

  • Update the db email address call to receive back email addresses in lower case format

Resources

@trillium trillium changed the title update db call to check for emails in lower case form OR update all email entries in db to be lower case Update db call to to receive email strings back from the db in lower case form Aug 26, 2023
@trillium trillium added this to the 04.01 Existing Features milestone Aug 26, 2023
@trillium
Copy link
Member Author

We're in luck here, the production DB only has two duplicate emails eg jeff@example, Jeff@example and ~40 emails that have upper case letters in them. Enough that a manual edit isn't a huge burden.

That means we don't need to update the DB call to return an email in lower case format. Win!

@trillium trillium assigned trillium and jbubar and unassigned trillium Aug 27, 2023
@bkmorgan3
Copy link
Member

@spiteless There is a { lowercase: true } value that can be added at the db layer to avoid all these manipulations on the FE.

@JackHaeg
Copy link
Member

This issue is being addressed by #1551. Once that ticket is finished, we can address this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

4 participants