Skip to content
This repository has been archived by the owner on Dec 6, 2019. It is now read-only.

embed iframes #74

Closed
bitboxer opened this issue Apr 30, 2012 · 12 comments
Closed

embed iframes #74

bitboxer opened this issue Apr 30, 2012 · 12 comments

Comments

@bitboxer
Copy link
Contributor

make it possible to embed hcking

@moonglum
Copy link
Member

moonglum commented Jul 4, 2012

iFrame? What the hell?! Is it 1995 again?

@bitboxer
Copy link
Contributor Author

bitboxer commented Jul 4, 2012

NO, iFrame is the way to go because of several reasons:

  1. We can change what is behind it easily
  2. No problems with css of the site

Show me a way to embed events in another website that has no problems with the css that is currently on that site. There are W3C Proposals to encapsulate embeded dom code with seperate css, but this has not landed in browsers yet.

AND iFrames are not 1995, Youtube, Vimeo and others recently switched to them from a javascript/object embed method because that way is easier.

@jhilden
Copy link
Contributor

jhilden commented Jul 4, 2012

I think it's feature that the sites CSS affects the embeded calendar.

If one goes with the iframe then it would be good to at least provide a way to load a custom stylesheet into the iframe.

Like:

%iframe{src="http://hcking.de/iframe?css=http://railslove.com/hcking.css"}

(using haml for the example because html didn't work)

@bitboxer
Copy link
Contributor Author

bitboxer commented Jul 4, 2012

It could be a feature, but for most people this would be a pain in the ass. If a non tech person wants to add the calender to their wordpress blog, they can't fiddle with the css that was provided by the theme they installed to make hcking look nice.

Adding a css with a param for us and giving several pre configured theme as a option for the user is a must do :)

@moonglum
Copy link
Member

moonglum commented Jul 4, 2012

Absolutely agree with @jhilden that it's a feature that the CSS changes the external stuff. No one wants an external thingy on his page that doesn't fit the design at all!

(Even though @jhilden didn't complete his post ^^)

@bitboxer
Copy link
Contributor Author

bitboxer commented Jul 4, 2012

@moonglum read my answer to this :)

@moonglum
Copy link
Member

moonglum commented Jul 4, 2012

Sorry, we posted at the same time.
I don't know if the argument is valid. Our audience are nerds. Most nerds know how to deal with that. If the "Social Media Gurus" come to our page we can still think about that...

@bitboxer
Copy link
Contributor Author

bitboxer commented Jul 4, 2012

If you look at the calender of droid boy you see social media dates. The focus of nerdhub will shift a little bit to a broader audience. And saying all users: "you have to modify the css if the embed breaks. It is not our fault." seems wrong to me. With iFrames we:

a) don't have any trouble at all
b) they work even without javascript (if you really want to focus the full 100% nerds, you need that ;) )
c) are fucking easy to embed

Why should we go into the world of pain to create embeds? And we can give the users the possibility to change the layout using css very easily if needed.

What is your point against iFrames? Only your gut feeling that they are old school? (which they are not ;) )

@moonglum
Copy link
Member

moonglum commented Jul 4, 2012

My argument is that iFrames are so unflexible. Yes, you can load your CSS into it. But as you said, Nerdhub can change the HTML any time – and all the wonderful CSS things you've done are worthless now. Do you want to send out "Newsletters about Changes to our embeddable iFrame"? I sure don't want to.

But I suggest the following:
We implement the iFrame functionality. Very simple thing – you give a day, week or month. You either give a white- or blacklist of tags. You optionally give a CSS.
If you want more: Use our #32 to embed it.

This gives our "power-users" the option to build an individual thing that fits their webpage. This allows the iFrame functionality to be very, very basic so we don't have to change it very often 👼

@bitboxer
Copy link
Contributor Author

bitboxer commented Jul 4, 2012

But the Javascript Embed could change, too. And the HTML the Javascript generates can change as often as the iFrame code. What is the difference? Your CSS Fix for the javascript embed is worthless, too, after that change :) .

And yes, iFrame + API is the ideal solution. That is why I opened both tickets ;) . /me is awesome :D

@moonglum
Copy link
Member

moonglum commented Jul 4, 2012

My solution would have been to provide a JavaScript snippet that gets the data from the API. You would put that on your own server, so it doesn't "just change" but you have to change it on your own. That allows you to do the CSS fixes when you have time and not when the funny nerdhub guys change their stuff.

But ok – we don't provide the snippet, instead we provide the iFrame. Yes, you are awesome :bowtie:

@moonglum
Copy link
Member

Moved to Backlog.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants