Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ACCESSIBILITY] Change HTML markup for a question back to radiogroup instead of markup with ARIA #49

Open
ghost opened this issue May 8, 2020 · 1 comment

Comments

@ghost
Copy link

ghost commented May 8, 2020

This issue is accessibility related.

Description:

The Single Choice Set functionality has much in common with a radiogroup form type. Therefore I would suggest a change back to a HTML markup that reflects a radiogroup for each question.

The reason for this is that a radiogroup let users know that there is some user input expected.

Currently a different set of semantics is communicated to users with assistive technology through ARIA. Of which the question as is is currently communicated as being an application. Application role is meant to use for desktop like applications, for example a draw application like paint.

Proposed solution:

(technical) related

Change the markup for the question + answer(s) sets to radiogroup HTML markup so that information and relationships are programmatically determinable for assistive technology.

Like:

<fieldset>
  <legend>Question?</legend>
  <div class="radio">
    <input type="radio" id="answer-1" name="singlechoice-question">
    <label for="answer-1">Answer 1</label>
  </div>
  <div class="radio">
    <input type="radio" id="answer-2" name="singlechoice-question">
    <label for="answer-2">Answer 2</label>
  </div>
  <div class="radio">
    <input type="radio" id="answer-3" name="singlechoice-question">
    <label for="answer-3">Answer 3</label>
  </div>
</fieldset>
@rvantonisse
Copy link

Hey 👋 ,

ℹ️ For your information:
checking in here as the "Ghost 👻 " issuer. I have merged my work related account, rvantonisse-accessibility, with my personal one.

And now that I am here I may be able to clarify or simplify the issue or request.

A lot of the semantics and functionality that has been implemented with ARIA and Javascript in single-choice-set (and other h5p modules) is already supported out of the box by standard HTML elements. While taking full control over the what and how aspects of user interface components give powerfull flexibility, the challenge with custom implementations is to cover all expected meaning and behaviour of these components.

I am curious about your thoughts and I would love to offer my help for accessibility improvements.

Cheers,
Roel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant