Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translations are all incorrect #17

Open
Jarvil opened this issue Mar 29, 2018 · 12 comments
Open

Translations are all incorrect #17

Jarvil opened this issue Mar 29, 2018 · 12 comments

Comments

@Jarvil
Copy link
Contributor

Jarvil commented Mar 29, 2018

Hello,

There is pretty bad bug in single choice set and translations in mod_hvp 1.7

f.ex in finnish translation Retry button is labeled "try again" and "try again" -button is labeled "retry" also all of the rest translations are wrong.

When moodle language is set to finnish everything seems fine in the translations but when you change moodle language to english you see how everything is wrong.

This might have something to do with that at least in finnish translation the first row in translation settings "Label for the "Next" button" that is shown in the english translations is missing all together.

and because of it all the translations skip to next available row and thus creating situation that every translation goes wron. @falcon-git

Finnish translations

Oikea vastaus = correct answer
Yritä uudelleen = try again

oik1

oik2

@timothyylim
Copy link
Contributor

Thanks for reporting this @Jarvil , I've been away for Easter but I'll make sure this is fixed today.

@Jarvil
Copy link
Contributor Author

Jarvil commented Apr 3, 2018

Hello,

Good to hear!

@timothyylim
Copy link
Contributor

It appears that the language files have deviated from the semantics file. I pushed a fix here:

c9b2ea6

It should be released as soon as possible.

@Jarvil
Copy link
Contributor Author

Jarvil commented Apr 5, 2018

Hello,

I don't see any fix yet?

@timothyylim
Copy link
Contributor

@Jarvil , the fix is on the master branch but it is still getting rolled out, I'll keep you updated.

@Jarvil
Copy link
Contributor Author

Jarvil commented Apr 9, 2018

Hello,

The fix isn't still available.

@Jarvil
Copy link
Contributor Author

Jarvil commented Apr 12, 2018

Hello,

the fix isn't still available @timothyylim

@timothyylim
Copy link
Contributor

Hi @Jarvil , an updated version of single choice set should be available through the hub. Can you check if you can download it?

@Jarvil
Copy link
Contributor Author

Jarvil commented Apr 12, 2018

Yes now I can download it, thank you.

@Jarvil
Copy link
Contributor Author

Jarvil commented Apr 12, 2018

Hello,

It seems the fix only affects new single choice set questions and you can't update the existing ones from
http://moodle.com/mod/hvp/library_list.php

@timothyylim
Copy link
Contributor

timothyylim commented May 30, 2018

Hi @Jarvil , thanks for being so patient. Has the bug affect all previous content types or just the ones you created on that particular version of single choice set?

@Jarvil
Copy link
Contributor Author

Jarvil commented May 31, 2018

After your patch new single choice set translations are correct but old ones are the same meaning they need to be fixed manually which isn't that great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants