Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config Flow: Implementation of Config Flow | Thread/Discussion & Documentation #46

Closed
robigan opened this issue Jun 28, 2022 · 6 comments

Comments

@robigan
Copy link
Contributor

robigan commented Jun 28, 2022

Hello World, summer holidays have started for me, and I've decided to work on implementing the config_flow.py into the vimar custom component.

Why does this issue exist? This issue exists to discuss the way config_flow.py should be implemented and to document any interesting findings along the way.
Where's the work on this feature? The work on this feature can be found on my fork of the repo

@h4de5
Copy link
Owner

h4de5 commented Jun 28, 2022

hi - there is a bigger change coming up here - config flow included: https://github.com/h4de5/home-assistant-vimar/tree/room_integrations
the problem is, that i do not have enough time to test it locally at the moment.

@robigan
Copy link
Contributor Author

robigan commented Jun 28, 2022

hi - there is a bigger change coming up here - config flow included: https://github.com/h4de5/home-assistant-vimar/tree/room_integrations the problem is, that i do not have enough time to test it locally at the moment.

Oh huh, I didn't notice, lol. I'll try integrating it into there. Also what exactly does the room_integrations branch feature exactly? Cus I don't recall there being support for rooms, do u mean integrating the "ambienti" feature into hass rooms?

@h4de5
Copy link
Owner

h4de5 commented Jun 28, 2022

each vimar entity (switch, light, cover etc) is located in a room. currently this is just visible through the unique_id/friendly name. with this change rooms frim vimar will show up in HA and can be easier used for automations

@robigan
Copy link
Contributor Author

robigan commented Jun 29, 2022

each vimar entity (switch, light, cover etc) is located in a room. currently this is just visible through the unique_id/friendly name. with this change rooms frim vimar will show up in HA and can be easier used for automations

Right, so I assume you mean the feature "ambienti" (Italian for ambient, but is usually also interpreted as areas/rooms). My only issue is that what if I wish not to implement the rooms found in the vimar project? For example my room mappings in HA are different than the ones in Vimar and wish to keep it that way. Point being is have you already implemented this some how or should I look into making a PR for such a thing?

@h4de5
Copy link
Owner

h4de5 commented Jun 29, 2022

to make sure that there are options for users who do not want to change things, is part of the testing.

@h4de5
Copy link
Owner

h4de5 commented Jul 24, 2022

closed via #48

@h4de5 h4de5 closed this as completed Jul 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants