-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not do rereading step in fread #2558
Conversation
@@ -184,6 +208,7 @@ class ParserIterator { | |||
value_type operator*() const; | |||
}; | |||
|
|||
// unused? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we remove ParserIterable ParserLibrary::successor_types(dt::read::PT pt) const;
method (that is not used anywhere anyways) ParserIterable
and ParserIterator
classes could be safely removed too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we need to do more cleanup around the ParserLibrary in general, but it's better to defer to a future PR.
Since the very early days, the design of fread was such that if any "type-bumps" happen in the middle of a file, then the corresponding column(s) will be marked as "require re-reading", and then at the end we would re-parse the entire file using the new column type. This approach has obvious drawbacks:
The new approach for handling type-bumping is the following:
Closes #1843
Closes #1446