Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement inner/outer joins for non-keyed frames #1080

Open
jangorecki opened this issue Jun 2, 2018 · 3 comments
Open

Implement inner/outer joins for non-keyed frames #1080

jangorecki opened this issue Jun 2, 2018 · 3 comments
Labels
High priority high-priority tasks improve Improvement of an existing functionality join

Comments

@jangorecki
Copy link
Contributor

jangorecki commented Jun 2, 2018

Creating issue so I can be notified when feature will be ready.
We can also discuss API related to this FR here.
pandas way

x.merge(y, how='inner', on='KEY')

data.table way

X[Y, on="KEY", nomatch=0L]

R data.frame way (also supported in data.table)

merge(X, Y, by="KEY", all=TRUE)
@jangorecki jangorecki added the join label Jun 2, 2018
@st-pasha st-pasha self-assigned this Jun 5, 2018
@jangorecki jangorecki added the High priority high-priority tasks label Jun 16, 2018
@st-pasha st-pasha changed the title join/merge data tables Implement inner/outer joins for non-keyed frames Jul 30, 2018
@st-pasha st-pasha added the improve Improvement of an existing functionality label Jul 30, 2018
@st-pasha
Copy link
Contributor

The API, as discussed in #1187, will be as follows:

X[:, :, join(Y, on="key", how="inner")]  # i.e. X.key == Y.key
X[:, :, join(Y, on=["xkey", "ykey"])]
X[:, :, join(Y, on=(f.xkey == g.ykey))]

The parameter how takes values inner, outer, left and right (same as in pandas), with "inner" being the default.

@st-pasha st-pasha mentioned this issue Jan 4, 2020
27 tasks
@anarchy89
Copy link

is there a way to do full outer join yet?

@oleksiyskononenko
Copy link
Contributor

@anarchy89 Nope, for the moment datatable only supports left outer joins. The issue gets closed when this feature is implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
High priority high-priority tasks improve Improvement of an existing functionality join
Projects
None yet
Development

No branches or pull requests

4 participants