Fix secure connections with new openssl #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdraco
commented
May 4, 2023
| "DEFAULT:!aNULL:!eNULL:!MD5:!3DES:!DES:!RC4:!IDEA:!SEED:!aDSS:!SRP:!PSK" | ||
| ) | ||
| # ssl.OP_LEGACY_SERVER_CONNECT is only available in Python 3.12a4+ | ||
| ssl_context.options |= getattr(ssl, "OP_LEGACY_SERVER_CONNECT", 0x4) |
There was a problem hiding this comment.
We are stuck with a getattr here since python/cpython#89051 the choice was made not to backport the new constant
|
I’m not near my computer until tonight. I’ll publish a new version of the lib then. |
|
I just published 2.2.2 of the elkm1_lib. |
|
thank you will get HA bumped |
bdraco
added a commit
to bdraco/roombapy
that referenced
this pull request
May 5, 2023
This is same fix as gwww/elkm1#69 but for roombas
pschmitt
pushed a commit
to pschmitt/roombapy
that referenced
this pull request
May 5, 2023
This is same fix as gwww/elkm1#69 but for roombas
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related issue home-assistant/core#92467