Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query string not captured #39

Open
wan54 opened this issue May 31, 2019 · 1 comment
Open

Query string not captured #39

wan54 opened this issue May 31, 2019 · 1 comment

Comments

@wan54
Copy link

wan54 commented May 31, 2019

Issue:

Which version are you using?

1.0.5

Are you using storybook-router with a react based project or a vue one?

React

Please describe the problem:

  • Link with query string <Link to={/page/1?status=bla>Bla</Link>. ?status=bla is not captured in actions logger.

  • Configuration with query string is not recognised

StoryRouter({
'/page/1?status=bla': linkTo('MyComponent, 'story')
})

Without QS works

StoryRouter({
'/page/1': linkTo('MyComponent, 'story')
})

Please explain how to reproduce the issue or (better) provide an example to do it.

  • Setup a Link with query string in it.
  • Configure StoryRouter with query string in it.
@bodograumann
Copy link

I can confirm this in the vue version as well.

When I call a route with parameters, they will not be shown in the actions panel. E.g.

<router-link :to="{
  name: 'my-route-name',
  params: { someParam: 42 }
  }"
>
Click here
</router-link>

would only show PUSH: (1) ["name: my-route-name"] when clicked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants