can you add a link to showing this

[alexec]

No description provided.

[guyarb]

hey @alexec!
Can you elaborate on your request? I didn't understand which link you are talking about, or where to add it

[alexec]

I'd like to see a build that is using this feature

[guyarb]

Updated the readme, now it contains a link to an example repo.

[alexec]

I get a 404 error:

https://github.com/guyarb/golang-test-annotations-example/actions/runs/505258482

[alexec]

Any chance you could take a look at my set-up:

argoproj/argo-workflows#4925

I didn't seem to get errors reported.

[guyarb]

@alexec , i opened the example repo to be public :)

and it looks like the output of your UI tests are not in the format that go test -json ./... > test.json

can you post the test.json file from your CI?

[alexec]

maybe it is gotestsum --jsonfile=test.json -- not working - I will investigate

[guyarb]

@alexec do you have any conclusions?

[alexec]

sorry - I gave up :(

[guyarb]

can you switch the test command line to go test -json ./... > test.json?

[displague]

@guyarb similar experience with https://github.com/equinix/terraform-provider-metal/pull/173/checks?check_run_id=3246845567

The errors were not annotated to the PR view. I'm not sure if this would have to be merged first or if the PR introducing golang-test-annotations should have been annotated.

https://github.com/equinix/terraform-provider-metal/pull/173/files

[guyarb]

@displague , I do see the errors were annotated https://github.com/equinix/terraform-provider-metal/actions/runs/1099517484

did i misunderstand you?

[displague]

@guyarb I see what you mean. I was expecting inline PR comments on failed tests, like https://github.com/reviewdog/reviewdog.

Is the problem that the test file/function/lines were not modified in the PR? If they were, perhaps the annotation would appear on that function?

[displague]

Here's a better example of what I was expecting:

https://github.com/WillAbides/go-test2action/pull/1/files

https://github.com/WillAbides/go-test2action/blob/main/internal/internal.go
https://github.com/WillAbides/ezactions/blob/master/commander.go#L106 (looks like you can specify col= too)

[displague]

Perhaps isaacs/github#284 (comment) is related and actions have no way to comment on lines (tests) that are not included in the PR.

[guyarb]

@displague, indeed when the PR added a failed test it adds preview on the diff (for https://github.com/guyarb/golang-test-annotations-example/pull/1/files)