Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sailor push not work as I expect with CupertinoTabScaffold innter TabViews. #23

Open
kishansinhparmarxongo opened this issue Dec 13, 2019 · 5 comments

Comments

@kishansinhparmarxongo
Copy link

How I push with sailor and without sailor.

Routes.sailor.navigate(
                          "Inner1",
                          navigationType: NavigationType.push,
            );

Navigator.of(context).push(
                        MaterialPageRoute(
                        builder: (context) => Inner1(),
                     ),
           );

My Flutter layout inspector.

Observe (with sailor)
3 bottom tabs
[Inner Tab Screen stack]
(https://github.com/kishansinhparmarxongo/resources_link/blob/master/Inner%20screen.png)

Expect (Without sailor)
3 bottom tabs
Inner Tab Screen

You can follow this link UX expect

@kishansinhparmarxongo
Copy link
Author

Something in context I tested today. If I create my own "onGenerateRoute" even it not works.
So problem somewhere around context.

@amrnt
Copy link

amrnt commented Dec 25, 2019

The way to fix this maybe to enable another optional routing with the context.

@kishansinhparmarxongo
Copy link
Author

Actualy I skipped sailor for my next upcomming projects let just grow sailor more stable. Thanks

@amrnt
Copy link

amrnt commented Dec 26, 2019

I understand. I'm trying to make some experiments around this.

In theory, the best way is would be routing using the closest GlobalKey<NavigatorState> in the tree. I tried to work around this with inherited widget etc but that was too much.

Let's see what @gurleensethi would say about this

@kishansinhparmarxongo
Copy link
Author

@amrnt Great to discuss with you.

Yes, With the same I also try to make my own navigation service with GlobalKey but its an experiement stage so I have not wider practise around it.

Hope something that @gurleensethi will find about it. I realy love sailor package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants