Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discussion] Don't mount $HOME if custom home #1

Open
gunnarx opened this issue Apr 8, 2022 · 1 comment
Open

[Discussion] Don't mount $HOME if custom home #1

gunnarx opened this issue Apr 8, 2022 · 1 comment
Labels
question Further information is requested

Comments

@gunnarx
Copy link
Owner

gunnarx commented Apr 8, 2022

I prefer that $HOME isn't mounted if a custom home was specified.

Draft implementation (WIP)
https://github.com/gunnarx/distrobox/tree/dont_mount_host_home

Still, choosing the --workdir seems not perfect (in either solution), but in my view it should at least not be host $HOME by default, if another HOME has been specified...

Some relevant notes:

which notes one of the problems (that appears also now) that --workdir set to a non-existing location will cause an error.

It would be good to protect the host's $HOME dir from applications in the container if a custom home is selected. Not mounting it at /home/<user> is a good start but it's still available through /run/host/home/<user> as things stand now. Sandboxing apps and isolating from personal files in $HOME is actually my main usage, but it's not the (current) way of the project.

Although, here is a discussion of that:

@gunnarx gunnarx added the question Further information is requested label Apr 8, 2022
@gunnarx
Copy link
Owner Author

gunnarx commented Apr 10, 2022

Apologies, you might find this because GitHub links everything together and because I mentioned issues above, but I intended this as preparation / personal notes on my own fork.

If an issue is required upstream I'd create a new one at: https://github.com/89luca89/distrobox/ (I already opened a PR, though...)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant