Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolved Issue 220: Replaced lodash w koalas #221

Merged
merged 2 commits into from
Feb 25, 2017
Merged

Resolved Issue 220: Replaced lodash w koalas #221

merged 2 commits into from
Feb 25, 2017

Conversation

rickyplouis
Copy link
Contributor

No description provided.

phated
phated requested changes Feb 25, 2017
View reviewed changes
Copy link
Member

@phated phated left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like to have the variables the same name as the package name. Just personal preference.

lib/prepare-write.js Outdated
@@ -4,7 +4,7 @@ var assign = require('object-assign');
var path = require('path');
var fs = require('graceful-fs');
var valueOrFunction = require('value-or-function');
var defaultTo = require('lodash.defaultto');
var defaultTo = require('koalas');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rename the variable to koalas

lib/src/index.js Outdated
@@ -8,7 +8,7 @@ var merge = require('merge-stream');
var sourcemaps = require('gulp-sourcemaps');
var isValidGlob = require('is-valid-glob');
var valueOrFunction = require('value-or-function');
var defaultTo = require('lodash.defaultto');
var defaultTo = require('koalas');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rename the variable to koalas

lib/symlink/index.js Outdated
@@ -5,7 +5,7 @@ var path = require('path');
var fs = require('graceful-fs');
var through2 = require('through2');
var valueOrFunction = require('value-or-function');
var defaultTo = require('lodash.defaultto');
var defaultTo = require('koalas');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rename the variable to koalas

@phated
Copy link
Member

phated commented Feb 25, 2017

👍

@phated phated merged commit 728df8e into gulpjs:master Feb 25, 2017
phated pushed a commit that referenced this pull request Nov 27, 2017
@rickyplouis @phated
Update: Replace lodash.defaultto with koalas (closes #220) (#221)
cb758ae
phated pushed a commit that referenced this pull request Nov 27, 2017
@rickyplouis @phated
Update: Replace lodash.defaultto with koalas (closes #220) (#221)
f9960bf
phated pushed a commit that referenced this pull request Nov 27, 2017
@rickyplouis @phated
Update: Replace lodash.defaultto with koalas (closes #220) (#221)
27c789f
phated pushed a commit that referenced this pull request Nov 27, 2017
@rickyplouis @phated
Update: Replace lodash.defaultto with koalas (closes #220) (#221)
1c137ee
phated pushed a commit that referenced this pull request Nov 27, 2017
@rickyplouis @phated
Update: Replace lodash.defaultto with koalas (closes #220) (#221)
fb40356
phated pushed a commit that referenced this pull request Nov 27, 2017
@rickyplouis @phated
Update: Replace lodash.defaultto with koalas (closes #220) (#221)
965a510
phated pushed a commit that referenced this pull request Nov 27, 2017
@rickyplouis @phated
Update: Replace lodash.defaultto with koalas (closes #220) (#221)
8ba0966
phated pushed a commit that referenced this pull request Nov 28, 2017
@rickyplouis @phated
Update: Replace lodash.defaultto with koalas (closes #220) (#221)
f79dc8f
phated pushed a commit that referenced this pull request Nov 28, 2017
@rickyplouis @phated
Update: Replace lodash.defaultto with koalas (closes #220) (#221)
97ef197
phated pushed a commit that referenced this pull request Nov 28, 2017
@rickyplouis @phated
Update: Replace lodash.defaultto with koalas (closes #220) (#221)
edc9162
phated pushed a commit that referenced this pull request Nov 28, 2017
@rickyplouis @phated
Update: Replace lodash.defaultto with koalas (closes #220) (#221)
020f0c3
phated pushed a commit that referenced this pull request Nov 28, 2017
@rickyplouis @phated
Update: Replace lodash.defaultto with koalas (closes #220) (#221)
e9ebc09
phated pushed a commit that referenced this pull request Nov 28, 2017
@rickyplouis @phated
Update: Replace lodash.defaultto with koalas (closes #220) (#221)
fd517fe
phated pushed a commit that referenced this pull request Nov 28, 2017
@rickyplouis @phated
Update: Replace lodash.defaultto with koalas (closes #220) (#221)
04c2701
phated pushed a commit that referenced this pull request Nov 28, 2017
@rickyplouis @phated
Update: Replace lodash.defaultto with koalas (closes #220) (#221)
3c87055
phated pushed a commit that referenced this pull request Nov 28, 2017
@rickyplouis @phated
Update: Replace lodash.defaultto with koalas (closes #220) (#221)
d1cbe57
phated pushed a commit that referenced this pull request Nov 28, 2017
@rickyplouis @phated
Update: Replace lodash.defaultto with koalas (closes #220) (#221)
122b424
phated pushed a commit that referenced this pull request Nov 28, 2017
@rickyplouis @phated
Update: Replace lodash.defaultto with koalas (closes #220) (#221)
ea6e3f3
phated pushed a commit that referenced this pull request Nov 28, 2017
@rickyplouis @phated
Update: Replace lodash.defaultto with koalas (closes #220) (#221)
b7000dc
phated pushed a commit that referenced this pull request Nov 28, 2017
@rickyplouis @phated
Update: Replace lodash.defaultto with koalas (closes #220) (#221)
c548acc
phated pushed a commit that referenced this pull request Nov 28, 2017
@rickyplouis @phated
Update: Replace lodash.defaultto with koalas (closes #220) (#221)
63e81c6
phated pushed a commit that referenced this pull request Nov 28, 2017
@rickyplouis @phated
Update: Replace lodash.defaultto with koalas (closes #220) (#221)
9ceefed
phated pushed a commit that referenced this pull request Nov 28, 2017
@rickyplouis @phated
Update: Replace lodash.defaultto with koalas (closes #220) (#221)
0f4cf4d
phated pushed a commit that referenced this pull request Nov 28, 2017
@rickyplouis @phated
Update: Replace lodash.defaultto with koalas (closes #220) (#221)
031fdee
phated pushed a commit that referenced this pull request Nov 28, 2017
@rickyplouis @phated
Update: Replace lodash.defaultto with koalas (closes #220) (#221)
45bdfbf
phated pushed a commit that referenced this pull request Nov 28, 2017
@rickyplouis @phated
Update: Replace lodash.defaultto with koalas (closes #220) (#221)
77b3270
phated pushed a commit that referenced this pull request Nov 30, 2017
@rickyplouis @phated
Update: Replace lodash.defaultto with koalas (closes #220) (#221)
112f032
phated pushed a commit that referenced this pull request Nov 30, 2017
@rickyplouis @phated
Update: Replace lodash.defaultto with koalas (closes #220) (#221)
d6b38f7
phated pushed a commit that referenced this pull request Nov 30, 2017
@rickyplouis @phated
Update: Replace lodash.defaultto with koalas (closes #220) (#221)
a277e19
phated pushed a commit that referenced this pull request Nov 30, 2017
@rickyplouis @phated
Update: Replace lodash.defaultto with koalas (closes #220) (#221)
13eb8fb
phated pushed a commit that referenced this pull request Nov 30, 2017
@rickyplouis @phated
Update: Replace lodash.defaultto with koalas (closes #220) (#221)
b12eca9
phated pushed a commit that referenced this pull request Dec 5, 2017
@rickyplouis @phated
Update: Replace lodash.defaultto with koalas (closes #220) (#221)
faea03c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phated phated phated approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rickyplouis @phated