Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken when using with typescript and "moduleResolution": "bundler" #142

Closed
abhishiv opened this issue Nov 11, 2023 · 3 comments
Closed
Assignees

Comments

@abhishiv
Copy link

abhishiv commented Nov 11, 2023

../../packages/rocky/rocky7/src/core/state.ts:2:28 - error TS7016: Could not find a declaration file for module '@gullerya/object-observer'. '/Users/shiva/Work/grati.co/node_modules/@gullerya/object-observer/dist/object-observer.min.js' implicitly has an 'any' type.
  There are types at '/Users/shiva/Work/grati.co/node_modules/@gullerya/object-observer/dist/object-observer.d.ts', but this result could not be resolved when respecting package.json "exports". The '@gullerya/object-observer' library may need to update its package.json or typings.

2 export { Observable } from "@gullerya/object-observer";

I think the fix is easy, just add types field to exports in package.json which it's missing right now

	"exports": {
		".": {
			"import": "./dist/object-observer.min.js",
			"require": "./dist/cjs/object-observer.min.cjs"
		}
	},
@gullerya
Copy link
Owner

Hi, thanks pointing that out, I see that recently there is some ongoing conversation about many packages broken this way.
I'll work on it.

@gullerya
Copy link
Owner

@abhishiv according to this site the 6.1.3 version resolved the issue, please verify on your side and update this issue with a new details or close.

@gullerya
Copy link
Owner

gullerya commented Dec 3, 2023

Closing as resolved, please open new issue if otherwise.

@gullerya gullerya closed this as completed Dec 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants