Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Needs update #59

Open
ghost opened this issue Mar 7, 2019 · 5 comments
Open

Needs update #59

ghost opened this issue Mar 7, 2019 · 5 comments

Comments

@ghost
Copy link

ghost commented Mar 7, 2019

Needs an update, multiple packages are depricated

Expected Behavior

should be updated

Current Behavior

mailcomposer and buildmail are unmaintained

Possible Solution

Update and find newer dependencies

Your Environment

Windows, Node 11x

@GreenPioneer
Copy link
Collaborator

@eclipsemain yea we will get this done within the week

@benbucksch
Copy link

@GreenPioneer : ping

@GreenPioneer
Copy link
Collaborator

GreenPioneer commented Jul 4, 2019

@benbucksch - thanks for the ping

Check this out - https://github.com/guileen/node-sendmail/tree/feature/%2359_update

let me know if it still works for you

I decided to pull the deprecated package in because we made a conscious decision in 1.0.0 that we did not want to get into the game of formatting emails properly. Picking a package like mail composer allowed up to add a ton of extra functionality because it was all in the formatting. Now that is deprecated it leaves us with 3 options

  1. pull in the deprecated packages and maintain them ourselves
  2. remove it and find an alternative
  3. go back to the basic formatting we had before

Im leaning toward option one as you see in the branch above

@CherryNerd
Copy link
Contributor

@GreenPioneer Is there a reason why they are deprecated?

@GreenPioneer
Copy link
Collaborator

@pixelplanetdev you are spot on with that and its fine if you want to switch back to nodemailer

I have thoughts about going back to the old way we build mail before we brought on buildmail but i dont know if would add enough value to the package because its due for a rewrite anyway

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants