Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README with proper case #6

Open
willieconrad opened this issue Oct 23, 2017 · 0 comments
Open

Update README with proper case #6

willieconrad opened this issue Oct 23, 2017 · 0 comments

Comments

@willieconrad
Copy link

In the README, there's an example of using ngECharts in a browser, with a script tag pointing to bower_components/ngecharts/dist/ngecharts.min.js, even though when you bower install the package it installs to bower_components/ngECharts/dist/ngecharts.min.js. For the most part, this case mismatch doesn't matter. However, if you are using gulp or some such tool to optimize all the JS in your project, it will scan your script tags for file to optimize, and if you are on a case-sensitive filesystem, it will fail to find this file. So probably best to update the README to use the same case as what's on disk.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant