Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a generalized hook into rate limit hits by providing a unidirectional channel to receive request/response data. The initial use case is to implement Prometheus metrics to monitor status of high value rate limit name/key pairs.
The user will populate
Config.EventChannel
with a channel and implement goroutine(s) to read from the channel. An event is triggered when a rate limit hit is applied at its owner peer and request/response structures are sent to the channel.This is intended to work for all peering behaviors: batching, non-batching, and global.
Other auxiliary changes:
golangci-lint
to latest.golangci-lint
inon-pull-request
workflow.cluster.StartWith()
extended with options arguments to add support forEventChannel
.