Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add isort to CI #990

Closed
4 tasks done
VakarisZ opened this issue Feb 24, 2021 · 2 comments · Fixed by #1081
Closed
4 tasks done

Add isort to CI #990

VakarisZ opened this issue Feb 24, 2021 · 2 comments · Fixed by #1081
Labels
Code Quality Deficiencies in code quality Complexity: Low DevOps Feature Issue that describes a new feature to be implemented. Impact: Medium

Comments

@VakarisZ
Copy link
Contributor

VakarisZ commented Feb 24, 2021

Is your feature request related to a problem? Please describe.
Isort was running on "fix" mode, we need to add the following line to travis.yaml and then fix all issues isort finds.

## Check import order
- python -m isort ./monkey --check-only --settings-file ./ci_scripts/isort.cfg

This is a prerequisite for #974.

  • Create/edit a configuration for isort, make sure isort config is compatible with black config. Ensure travis uses the same configuration. (0d) - @shreyamalviya
  • Edit travis config so that the build fails if isort finds any issues. (0d)
  • Reformat all imports with isort (0.25d) - @mssalvatore
  • Run blackbox and unit tests to ensure nothing wonky happened (0d) - @mssalvatore
@VakarisZ VakarisZ added Feature Issue that describes a new feature to be implemented. DevOps Impact: Medium Complexity: Low Code Quality Deficiencies in code quality labels Feb 24, 2021
@mssalvatore
Copy link
Collaborator

This might be helpful information: https://black.readthedocs.io/en/stable/compatible_configs.html#isort

@mssalvatore
Copy link
Collaborator

$> isort --help
...
  -c, --check-only, --check
                        Checks the file for unsorted / unformatted imports and prints them to the command line without modifying the file. Returns 0 when
                        nothing would change and returns 1 when the file would be reformatted.
...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Quality Deficiencies in code quality Complexity: Low DevOps Feature Issue that describes a new feature to be implemented. Impact: Medium
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants