Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BB test performance: skip connectivity check #1371

Closed
1 task done
VakarisZ opened this issue Jul 27, 2021 · 0 comments · Fixed by #1388
Closed
1 task done

BB test performance: skip connectivity check #1371

VakarisZ opened this issue Jul 27, 2021 · 0 comments · Fixed by #1388
Labels
Complexity: Low Feature Issue that describes a new feature to be implemented. Impact: Low

Comments

@VakarisZ
Copy link
Contributor

VakarisZ commented Jul 27, 2021

Is your feature request related to a problem? Please describe.
Monkeys do an internet connectivity check (where do we even display this information?), which takes up to a minute (especially if the internet is unavailable):

2021-06-30 07:16:15,039 [1844:140651882833664:DEBUG] control.wakeup.45: parent: 237567998424320
 2021-06-30 07:16:15,040 [1844:140651882833664:DEBUG] connectionpool._new_conn.959: Starting new HTTPS connection (1): updates.infectionmonkey.com:443
 2021-06-30 07:17:15,150 [1844:140651882833664:DEBUG] connectionpool._new_conn.959: Starting new HTTPS connection (1): www.google.com:443
 2021-06-30 07:17:30,175 [1844:140651882833664:DEBUG] connectionpool._new_conn.959: Starting new HTTPS connection (1): 10.2.2.251:5000
 2021-06-30 07:17:30,203 [1844:140651882833664:DEBUG] connectionpool._make_request.437: https://10.2.2.251:5000 \"POST /api/monkey HTTP/1.1\" 200 34
2021-07-26 05:14:10,771 [2745:139797814303616:DEBUG] monkey.set_default_server.461: default server set to: 192.168.10.1:5000
2021-07-26 05:14:10,772 [2745:139797814303616:DEBUG] control.wakeup.48: parent: 211375648895908
2021-07-26 05:14:10,773 [2745:139797814303616:DEBUG] connectionpool._new_conn.943: Starting new HTTPS connection (1): updates.infectionmonkey.com:443
2021-07-26 05:14:27,625 [2745:139797814303616:DEBUG] connectionpool._new_conn.943: Starting new HTTPS connection (1): www.google.com:443
2021-07-26 05:14:47,650 [2745:139797814303616:DEBUG] connectionpool._new_conn.943: Starting new HTTPS connection (1): 192.168.10.1:5000
2021-07-26 05:14:47,675 [2745:139797814303616:DEBUG] connectionpool._make_request.442: https://192.168.10.1:5000 "POST /api/monkey HTTP/1.1" 200 34
2021-07-26 05:14:47,677 [2745:139797814303616:DEBUG] connectionpool._new_conn.943: Starting new HTTPS connection (1): 192.168.10.1:5000

This is not common however, thus this issue has a low priority.

Describe the solution you'd like
Disable internet connectivity check for unit tests by modifying the default template to not contain any internet addresses to check.

Describe alternatives you've considered
Keeping as is

Tasks

  • Change the default blackbox configuration templates to not have any internet addresses to query (internal -> monkey -> internet_services) (0d) @ilija-lazoroski
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Low Feature Issue that describes a new feature to be implemented. Impact: Low
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant