Fix Prosemirror tests which pass in CI, but fail locally #376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mainly because some tests were failing locally but not in CI
|
Unfortunately bumping to the newest Cypress version breaks some other tests. This is due to a regression in Cypress. I've opened a PR to fix. This PR is blocked until the Cypress PR is merged and released |
|
The Cypress PR has been merged and is awaiting release. We will probably see a release in the next two weeks (based on the average cadence of the release schedule). |
What do you know, it's now out: https://github.com/cypress-io/cypress/releases/tag/v13.7.2 |
|
Tests now passing locally 👍 |
Fweddi
approved these changes
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are some element movement tests in ElementWrapper which are a bit flaky - they fail locally but pass in CI.
The helper function getElementType in editor.ts seems to fail to find the elementWrapperTestId for an element, which means its returns unknown and fails the test.
Fixed by bumping Cypress version