Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: AU news curated content collection doesn't exist #25453

Closed
bryophyta opened this issue Sep 5, 2022 · 7 comments
Closed

Bug: AU news curated content collection doesn't exist #25453

bryophyta opened this issue Sep 5, 2022 · 7 comments
Labels
Bug Fronts 📰 Related to the migration of front pages to DCR

Comments

@bryophyta
Copy link
Contributor

bryophyta commented Sep 5, 2022

We fetch curated content for 'Onwards' containers using a hard-coded list of collection ids. This includes au-alpha/news/regular-stories. But there is no collection with that id in the current PROD fronts config, so no data is fetched for Australian news articles.

UK edition has two containers, as it should

Image

https://www.theguardian.com/australia-news/2022/aug/31/federal-icac-independents-want-safeguards-to-ensure-body-cannot-be-politicised

AU edition only has one container, when it should have two

screenshot of page with no curated content loaded

This collection id does exist in the CODE fronts config, so my guess is that it has been removed from PROD at some point (rather than it being a typo or something). If this is correct, we probably need an editorial decision about which collection to use instead for AU/News curated content.

nb. This is a bug both in the existing site and in the new curated content agent that's being created at the moment. If we get a new id, it should just be a one-line change in either codebase, however.

If we're going to talk to editorial about this, it may also be worth exploring whether there are any options which would allow us to avoid relying on a hard-coded list of ids altogether.

@Georges-GNM
Copy link
Contributor

@AshCorr think you mentioned in a recent tools catchup you were looking at this?

@bryophyta
Copy link
Contributor Author

@AshCorr sorry I can't believe that when we were pairing on this the other day I'd totally forgotten I'd opened this issue! 🤦

@Georges-GNM Georges-GNM moved this from To Triage to In Progress in Deprecated: WebX Health and Rota Dec 7, 2022
@AshCorr
Copy link
Member

AshCorr commented Dec 8, 2022

This should be fixed now! but perhaps we want to keep this ticket for discussing how we improve onwards?

guardian/dotcom-rendering#6549

@Georges-GNM
Copy link
Contributor

Hey both, not familiar enough with onwards to have a sense of how much work there might be in improving it, but I'm inclined to suggest creating a new ticket (or maybe an rfc/doc) for that, and this one can be closed?

@bryophyta
Copy link
Contributor Author

@Georges-GNM sounds good! Tbh there are a few different issues in this area. I don't think we've got a ticket for the issue which underlies this particular bug though, so I'll create one now.

Repository owner moved this from Doing to Done in Deprecated: WebX Health and Rota Dec 8, 2022
@Georges-GNM
Copy link
Contributor

Georges-GNM commented Dec 8, 2022

Thanks @bryophyta! Will close this ticket then. (edit: didn't see you'd already done it)

@bryophyta
Copy link
Contributor Author

new issue created here: guardian/dotcom-rendering#6732

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Fronts 📰 Related to the migration of front pages to DCR
Projects
No open projects
Development

No branches or pull requests

3 participants