From 6b63bd486081990f197d5dfc5bfcbe52a20aa1ea Mon Sep 17 00:00:00 2001 From: "github-actions[bot]" Date: Thu, 5 Dec 2024 17:25:48 +0000 Subject: [PATCH 1/2] Bump package version --- .changeset/friendly-trainers-cry.md | 16 ---------------- .changeset/soft-scissors-turn.md | 5 ----- CHANGELOG.md | 21 +++++++++++++++++++++ package.json | 2 +- 4 files changed, 22 insertions(+), 22 deletions(-) delete mode 100644 .changeset/friendly-trainers-cry.md delete mode 100644 .changeset/soft-scissors-turn.md diff --git a/.changeset/friendly-trainers-cry.md b/.changeset/friendly-trainers-cry.md deleted file mode 100644 index 0d8b7fbed4..0000000000 --- a/.changeset/friendly-trainers-cry.md +++ /dev/null @@ -1,16 +0,0 @@ ---- -"@guardian/cdk": major ---- - -Support multiple usages of `GuGithubActionsRole` in a single AWS account - -This significantly changes the resources constructed by `GuGithubActionsRole`, -specifically, **the construct will no longer instantiate a `GitHubOidcProvider`**. -This is because you can only ever have one `GitHubOidcProvider` per provider -domain (ie `token.actions.githubusercontent.com`) - while we may want multiple -instances of `GuGithubActionsRole` in an AWS account, we can't have the -`GuGithubActionsRole` construct trying to make a new `GitHubOidcProvider` with -each instance. - -Consequently, you will need to instantiate the `GitHubOidcProvider` elsewhere -as a singleton. At the Guardian, we do this with https://github.com/guardian/aws-account-setup. diff --git a/.changeset/soft-scissors-turn.md b/.changeset/soft-scissors-turn.md deleted file mode 100644 index fd0c3f1f12..0000000000 --- a/.changeset/soft-scissors-turn.md +++ /dev/null @@ -1,5 +0,0 @@ ---- -"@guardian/cdk": minor ---- - -Default to GP3 storage type for RDS diff --git a/CHANGELOG.md b/CHANGELOG.md index 09cf142c66..9b949588a2 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,26 @@ # @guardian/cdk +## 61.0.0 + +### Major Changes + +- d3259e7: Support multiple usages of `GuGithubActionsRole` in a single AWS account + + This significantly changes the resources constructed by `GuGithubActionsRole`, + specifically, **the construct will no longer instantiate a `GitHubOidcProvider`**. + This is because you can only ever have one `GitHubOidcProvider` per provider + domain (ie `token.actions.githubusercontent.com`) - while we may want multiple + instances of `GuGithubActionsRole` in an AWS account, we can't have the + `GuGithubActionsRole` construct trying to make a new `GitHubOidcProvider` with + each instance. + + Consequently, you will need to instantiate the `GitHubOidcProvider` elsewhere + as a singleton. At the Guardian, we do this with https://github.com/guardian/aws-account-setup. + +### Minor Changes + +- bf08a5e: Default to GP3 storage type for RDS + ## 60.1.3 ### Patch Changes diff --git a/package.json b/package.json index be9497c497..d032fa1196 100644 --- a/package.json +++ b/package.json @@ -1,7 +1,7 @@ { "name": "@guardian/cdk", "description": "Generic Guardian flavoured AWS CDK components", - "version": "60.1.3", + "version": "61.0.0", "main": "lib/index.js", "types": "lib/index.d.ts", "files": [ From 40d299517957492f07ebfa018f6747e0613d0c6b Mon Sep 17 00:00:00 2001 From: Roberto Tyley <52038+rtyley@users.noreply.github.com> Date: Thu, 5 Dec 2024 17:31:46 +0000 Subject: [PATCH 2/2] Empty commit to trigger build