Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: GHA possibly not writing build.json. Otherwise other bug leads to no RiffRaff deploy #173

Open
tylr-mk opened this issue Oct 22, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@tylr-mk
Copy link

tylr-mk commented Oct 22, 2024

We've noticed this happen 2 times in approximately 2 weeks, but that's only from "known" failures to deploy. So I suspect there could be more cases.

We've observed intermittent failure where RiffRaff will not register a build and therefore not run Continuous Deployment following a RiffRaff GitHub Action. Best guess is there's some exit of the runtime before successful run of this block.

We have PR > Build 1 (on merge) > Build 2 (manually run this morning). Both builds create the Build number 11396. And the second manual run this morning triggered the RiffRaff build

Both exit 0. But pulling the tail of the logs shows only the successful run second prints "Upload Complete". Naive guess is that's this here.

  1. unsuccessful
s3 sync: staging-JEjyzu/cloud-composer-deployment/dags/guardian/utils/teams.py -> ophan:data-lake:airflow/11396/cloud-composer-deployment/dags/guardian/utils/teams.py
s3 sync: staging-JEjyzu/riff-raff.yaml -> ophan:data-lake:airflow/11396/riff-raff.yaml
  1. successful
s3 sync: staging-Cvk9Yh/cloud-composer-deployment/dags/guardian/utils/teams.py -> ophan:data-lake:airflow/11396/cloud-composer-deployment/dags/guardian/utils/teams.py
s3 sync: staging-Cvk9Yh/riff-raff.yaml -> ophan:data-lake:airflow/11396/riff-raff.yaml
Upload complete.
...
@tylr-mk tylr-mk changed the title No write of build.json leads to know RiffRaff deploy No write of build.json leads to no RiffRaff deploy Oct 22, 2024
@tylr-mk tylr-mk changed the title No write of build.json leads to no RiffRaff deploy BUG: No write of build.json leads to no RiffRaff deploy Oct 22, 2024
@tylr-mk tylr-mk added the bug Something isn't working label Oct 22, 2024
@tylr-mk tylr-mk changed the title BUG: No write of build.json leads to no RiffRaff deploy BUG: GHA possibly not writing build.json. Otherwise other bug leads to no RiffRaff deploy Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant