Extract code from signal handlers into methods #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow building other mechanisms to interact with Guard, for example on JRuby, where signal handling tends to be unreliable.
|
That's a good idea, Windows also have problems with interactor (#49 (comment)). We also need to found a workaround for windows :)/ Thanks! |
thibaudgg
added a commit
that referenced
this pull request
May 6, 2011
Extract code from signal handlers into methods
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow building other mechanisms to interact with Guard, for
example on JRuby, where signal handling tends to be unreliable.
For example, I'm planning on making a JMX-based interactor for JRuby. Maybe a little bit heavy-weight, and sucks that we can't use signals, but it's a fun exercise.