[Azure] Unable to check if key vault secret exists using environment variables

[victornoventa]

I have had issues while running my tests that rely on modules/azure/keyvault to check if a secret exists. I have everything set as the instructions tell me to do and everything goes fine with my service principal information set as environment variables. But I can't check if a secret exists because it relies on Az CLI instead. Is there any specific reason for having this relying on NewAuthorizerFromCLI

terratest/modules/azure/keyvault.go

Line 127 in d1ce8be

authorizer, err := kvauth.NewAuthorizerFromCLI()

Instead of relying on NewAuthorizerFromEnvironment?

https://github.com/Azure/azure-sdk-for-go/blob/master/services/keyvault/auth/auth.go#L19

I mean, I've seen other places using this Authorizer instead:

terratest/modules/azure/authorizer.go

Line 24 in d1ce8be

func NewAuthorizer() (*autorest.Authorizer, error) {

[HadwaAbdelhalem]

@victornoventa Operations on Azure Keyvault are 2 groups, first group "Management plan "that creates, update or detele the vault and set the permissions on it. the second group "Data plan" that add, updates, retrieve, or deletes the values stored within the vault

To run any operation on the data within azure keyvault you need to use a data plan Authorizer, while the remaining resources operations are using the management plan authorizer.

With that said, I think we should expand the newKeyVaultAuth

terratest/modules/azure/keyvault.go

Line 126 in d1ce8be

func NewKeyVaultAuthorizerE() (*autorest.Authorizer, error) {

to offer the same flexibity the newAuthorizer offers

terratest/modules/azure/authorizer.go

Line 24 in d1ce8be

func NewAuthorizer() (*autorest.Authorizer, error) {

For more details please check this

[HadwaAbdelhalem]

@victornoventa a fix was merged to address this issue.