-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docker] Helper function to get exposed host ports for -P flag #807
Merged
yorinasub17
merged 2 commits into
gruntwork-io:master
from
ThelonKarrde:feature/docker_port_selector
Mar 17, 2021
Merged
[docker] Helper function to get exposed host ports for -P flag #807
yorinasub17
merged 2 commits into
gruntwork-io:master
from
ThelonKarrde:feature/docker_port_selector
Mar 17, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThelonKarrde
changed the title
[docker] Function to get exposed host ports for -P flag
[docker] Helper function to get exposed host ports for -P flag
Mar 13, 2021
yorinasub17
reviewed
Mar 17, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution! The LGTM, except for one doc change. Will kick off a build shortly so you get one test cycle.
Co-authored-by: Yoriyasu Yano <[email protected]>
yorinasub17
approved these changes
Mar 17, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This was referenced Mar 17, 2021
Merged
Closed
Closed
This was referenced Mar 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to:
docker
moduleThe problem:
If you have at least two concurrent builds of the same image with exposed ports to host on the same build agent (on whatever CI tool you use) you unable to use direct port mapping. So you must use
-P
flag for therun
command to get random host port assignments and then use theinspect
function to get a list of exposed and mapped ports and choose the port that you want to test from this list. However, if you have more than two ports you might not know under what index will be this port or you need to check Dockerfile if you changed the order and make changes to test. Otherwise, you can write your own helper to search in the port list and migrated it from one project/test to another.It's sort of painful to maintain and uncomfortable to use.
The solution:
I simply added a helper for host port search to the
ContainerInspect
structure as a function.I'm not sure is it a convenient place for this helper, so let me know if I need to move it somewhere else in the package or it might just doesn't make sense :)
p.s. I also write a test to make sure that the helper works as expected, as an "error code" I'm using
0
value.