Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename gruntwork-cli to go-commons #806

Merged
merged 1 commit into from
Mar 11, 2021
Merged

Rename gruntwork-cli to go-commons #806

merged 1 commit into from
Mar 11, 2021

Conversation

yorinasub17
Copy link
Contributor

No description provided.

@yorinasub17 yorinasub17 requested a review from brikis98 as a code owner March 11, 2021 16:35
brikis98
brikis98 approved these changes Mar 11, 2021
View reviewed changes
Copy link
Member

@brikis98 brikis98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yorinasub17
Copy link
Contributor Author

Thanks for review. Will wait for build to finish before merging!

infraredgirl
infraredgirl approved these changes Mar 11, 2021
View reviewed changes
Copy link
Contributor

@infraredgirl infraredgirl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, the new name go-commons definitely makes more sense.

@yorinasub17
Copy link
Contributor Author

Ok build passed except for known issue with GCP. Going to merge this in! Thanks for review!

@yorinasub17 yorinasub17 merged commit 7f09936 into master Mar 11, 2021
@yorinasub17 yorinasub17 deleted the yori-renamegocommons branch March 11, 2021 21:08
This was referenced Mar 12, 2021
Closed
Merged
Closed
Closed
Closed
Closed
Closed
Closed
Merged
Closed
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Closed
Closed
Merged
This was referenced Mar 16, 2021
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Merged
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infraredgirl infraredgirl infraredgirl approved these changes

@brikis98 brikis98 brikis98 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yorinasub17 @brikis98 @infraredgirl